Getting uncached mode to work #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… interval (by default 10 seconds) to allow the browser to download the cache first.
… Rails actions or directories).
|
works for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, Rack::Offline offers an uncached mode in which the manifest is constantly regenerated; it's a great idea for development (and is on by default in dev environment), but doesn't actually work. The problem is that the cache-breaking comment in the manifest is generated by the following line:
Since the browser downloads the cache twice (once at the beginning, and once at the end for verification), the use of usec means the manifest will always be different and the app cache can never be built.
I've written a patch (with tests) to change this behavior; with these changes, the comment will only change after a configurable interval (by default 10 seconds) to allow the browser to download the cache first. (There's always a risk that the download will start too close to the boundary, but since this is development only, the developer can adjust the interval to his or her preference.)
PS thanks for the very useful gem! I remember hearing about it in a side talk at the jQuery conference last year in Mountain View, and am very excited to finally be using it.