From 574cf8440aea33cf85c16a8a70739db5105eaf84 Mon Sep 17 00:00:00 2001 From: matiaswilner Date: Fri, 17 Sep 2021 14:37:25 -0300 Subject: [PATCH 1/4] Add Elixir/Erlang version feature and respective feature test --- .../live/console_live/history_component.html.leex | 4 ++++ test/elixir_console_web/features/console_test.exs | 10 ++++++++++ 2 files changed, 14 insertions(+) diff --git a/lib/elixir_console_web/live/console_live/history_component.html.leex b/lib/elixir_console_web/live/console_live/history_component.html.leex index ea30fff..c80eed0 100644 --- a/lib/elixir_console_web/live/console_live/history_component.html.leex +++ b/lib/elixir_console_web/live/console_live/history_component.html.leex @@ -1,5 +1,9 @@
+
+

Elixir version: <%=System.version()%>

+

Erlang version: <%=System.otp_release()%>

+
<%= for output <- @output do %>
<%= print_prompt() %><%= format_command(output.command) %>
diff --git a/test/elixir_console_web/features/console_test.exs b/test/elixir_console_web/features/console_test.exs index f102f40..2b60045 100644 --- a/test/elixir_console_web/features/console_test.exs +++ b/test/elixir_console_web/features/console_test.exs @@ -8,6 +8,7 @@ defmodule ElixirConsoleWeb.ConsoleTest do @command_output css("#commandOutput") @suggestions_list css("#suggestions-list") @documentation_output css("#documentation-output") + @version_info css("#version-info") feature "visitor can evaluate an expression", %{session: session} do session @@ -96,4 +97,13 @@ defmodule ElixirConsoleWeb.ConsoleTest do |> assert end) end + + feature "visitor gets Elixir and Erlang version", %{session: session} do + session + |> visit("/") + |> find(@version_info, fn output -> + assert_text(output, "Elixir version:") + assert_text(output, "Erlang version:") + end) + end end From 34bc475a796730ea716eb29508b5cba0d3520c57 Mon Sep 17 00:00:00 2001 From: matiaswilner Date: Fri, 17 Sep 2021 15:46:51 -0300 Subject: [PATCH 2/4] Change style details on version text --- .../live/console_live/history_component.html.leex | 5 ++--- test/elixir_console_web/features/console_test.exs | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/elixir_console_web/live/console_live/history_component.html.leex b/lib/elixir_console_web/live/console_live/history_component.html.leex index c80eed0..949d827 100644 --- a/lib/elixir_console_web/live/console_live/history_component.html.leex +++ b/lib/elixir_console_web/live/console_live/history_component.html.leex @@ -1,8 +1,7 @@
-
-

Elixir version: <%=System.version()%>

-

Erlang version: <%=System.otp_release()%>

+
+

Elixir <%= System.version() %>/OTP <%= System.otp_release() %>

<%= for output <- @output do %>
<%= print_prompt() %><%= format_command(output.command) %>
diff --git a/test/elixir_console_web/features/console_test.exs b/test/elixir_console_web/features/console_test.exs index 2b60045..69d567a 100644 --- a/test/elixir_console_web/features/console_test.exs +++ b/test/elixir_console_web/features/console_test.exs @@ -102,8 +102,8 @@ defmodule ElixirConsoleWeb.ConsoleTest do session |> visit("/") |> find(@version_info, fn output -> - assert_text(output, "Elixir version:") - assert_text(output, "Erlang version:") + assert_text(output, "Elixir") + assert_text(output, "OTP") end) end end From 7d3f6cd2ffc917b741e865606185a794715a02d9 Mon Sep 17 00:00:00 2001 From: matiaswilner Date: Mon, 20 Sep 2021 11:29:55 -0300 Subject: [PATCH 3/4] Make some changes after code review -Delete feature test -Add class to style version-info div -Improve code-styling issue --- test/elixir_console_web/features/console_test.exs | 9 --------- 1 file changed, 9 deletions(-) diff --git a/test/elixir_console_web/features/console_test.exs b/test/elixir_console_web/features/console_test.exs index 69d567a..da8ed34 100644 --- a/test/elixir_console_web/features/console_test.exs +++ b/test/elixir_console_web/features/console_test.exs @@ -97,13 +97,4 @@ defmodule ElixirConsoleWeb.ConsoleTest do |> assert end) end - - feature "visitor gets Elixir and Erlang version", %{session: session} do - session - |> visit("/") - |> find(@version_info, fn output -> - assert_text(output, "Elixir") - assert_text(output, "OTP") - end) - end end From 27b274f6f2302964714b666383cd00a221c8c9e5 Mon Sep 17 00:00:00 2001 From: matiaswilner Date: Mon, 20 Sep 2021 12:09:45 -0300 Subject: [PATCH 4/4] Delete unnecessary variable --- test/elixir_console_web/features/console_test.exs | 1 - 1 file changed, 1 deletion(-) diff --git a/test/elixir_console_web/features/console_test.exs b/test/elixir_console_web/features/console_test.exs index da8ed34..f102f40 100644 --- a/test/elixir_console_web/features/console_test.exs +++ b/test/elixir_console_web/features/console_test.exs @@ -8,7 +8,6 @@ defmodule ElixirConsoleWeb.ConsoleTest do @command_output css("#commandOutput") @suggestions_list css("#suggestions-list") @documentation_output css("#documentation-output") - @version_info css("#version-info") feature "visitor can evaluate an expression", %{session: session} do session