Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

Can't type in a table cell #228

Closed
jlashomb opened this issue Feb 10, 2011 · 6 comments
Closed

Can't type in a table cell #228

jlashomb opened this issue Feb 10, 2011 · 6 comments

Comments

@jlashomb
Copy link

When creating a new table in Firefox, any of the cells that were made from the pop-up form can be clicked into, but you can't enter text. Any cells that are added through the firefox editable frame table tools seem to work fine.

@jlashomb
Copy link
Author

Found a fix on the forums where the JS was tweaked to add default text into the cells and that seemed to fix it. I set the newly add default text to be '<br _moz_editor_bogus_node="TRUE" style="display:table-cell;" _moz_dirty="">' and set it to only add text for Firefox. The styling makes the <br> hidden and the '_moz_editor_bogus_node="TRUE"' filters it as part of Firefox's editable frame.

@jlashomb
Copy link
Author

--- //webtest/wwwroot/drupal-6/sites/all/libraries/wymeditor/wymeditor/original/jquery.wymeditor.js Thu Jun 03 13:54:48 2010

+++ //webtest/wwwroot/drupal-6/sites/all/libraries/wymeditor/wymeditor/jquery.wymeditor.js Thu Feb 10 11:24:38 2011

@@ -1530 +1530,6 @@

- for(y=0; y<iCols; y++) {newRow.insertCell(y);}

+ for(y=0; y<iCols; y++) {

+ var newCell = newRow.insertCell(y);

+ if(jQuery.browser.mozilla){

+ newCell.innerHTML = '
';

+ }

+ }

@jonatansberg
Copy link
Member

This should be at least partially fixed (see 830f1cc).

@winhamwr
Copy link
Member

Still not quite fixed. With current master, once you insert a new table you have to click in a cell, out of the cell and back in to insert content. Otherwise your typing has no result.

@winhamwr
Copy link
Member

Added a pull request to narrow the affected case to only manual HTML insertion of a table: #235

@jonatansberg
Copy link
Member

This will have to do for now. The only case thats not covered is tables inserted using the html-view, which are still editable on double click or by navigating the table using the keyboard.

winhamwr added a commit to winhamwr/wymeditor that referenced this issue Jul 13, 2011
…space next to a header would turn it in to a paragraph
winhamwr added a commit that referenced this issue Jul 13, 2011
Refs gh-228. FF bug- double-clicking whitespace changes h2 to p tag
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants