Image resizing #747
Image resizing #747
Conversation
|
There was some work in #641. That is good work. That is the best way that I've found to handle selection of images in That is selecting images like text. Selecting images like text contradicts with the native image selection interface, which provides the resize handles. I don't think that this is good. |
|
Is there no way to mix the two so that selection is like text, but image resizing is still possible? |
|
@winhamwr I'm working on a resizing handle, which looks like this at the moment:
What do you think about the UI, the UX and these points? |
|
@mightyiam Nice, I personnely don't see nothing frustrating in "drag to resize". It's like as it meant to be in WYSIWYM: you mean it, so editor directs numerous user to "drag" this and then get expected result - "resize". By other side, when developer uses markers, they are kinda "invisible" for newbies (or the most annoying - markers may be too little to catch). Your solution is good enough for this time. |
|
I think a custom resize controller is probably a good idea from a first-best scenario. How long do you think it will take to get something like that done and up to the same level of usability as the native controls? |
|
I'll probably get most of the functionality working today. Then, the parser part, which needs to extract the image from the container. I'm not sure how that is done at all, since we have support in the parser for ignoring editor-only elements, but here we have the element we'd like to ignore containing elements we'd like to keep, instead of it. Perhaps I'll unwrap all the images in DOM, before any |
|
Wonderful and smooth in Chrome and Firefox, so far. A few issues remain. I've listed them in the description. The first item, the image cropping instead of scaling in IE is the only thing I don't have a clue on. |
|
Perhaps cause a reload of the image |
| @@ -51,9 +51,6 @@ WYMeditor.WymClassTrident7.prototype._docEventQuirks = function () { | |||
| jQuery(wym._doc).bind("keyup", function (evt) { | |||
| wym._keyup(evt); | |||
| }); | |||
| jQuery(wym._doc).bind("click", function (evt) { | |||
| wym._click(evt); | |||
| }); | |||
There was a problem hiding this comment.
This is unrelated and was completely useless.
There was a problem hiding this comment.
This was as if we had a Trident 7 specific click handler. But we don't
| * SVG images are not scaled. | ||
| * They are cropped. That's right. | ||
| * And applying style to them does not help, | ||
| * as well. Ideas are welcome. |
There was a problem hiding this comment.
that sucks, wish I knew more about SVG to help. I know there are weird quirks between img & object and the other ways of embedding svg, but I don't know the specifics
|
I tried. :) some comments in resizehandler to consider, besides that it looks good. |
Spec
After Merging