New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaned Up Vue Modal Styling #112

Merged

wynnset merged 5 commits into tapestry-d3-vue from 111-clean-up-css

Sep 18, 2019

Contributor

nandanmen commented Sep 12, 2019

Fixes #111

Changes:

Fixed font size being too large
Changed modal paddings and margins to look cleaner
Changed common elements to use classes instead of ids


          Updated modal styles

25a84b2

hound bot reviewed

View reviewed changes

templates/tapestry-d3-vue/webpack.config.js Outdated

+                  new webpack.LoaderOptionsPlugin({
+                    minimize: true
+                  })
+                ])

hound bot Sep 12, 2019

Missing semicolon.

templates/tapestry-d3-vue/webpack.config.js Outdated

+              }
+              if (process.env.NODE_ENV === 'production') {
+                module.exports.devtool = '#source-map'

hound bot Sep 12, 2019

Missing semicolon.

templates/tapestry-d3-vue/webpack.config.js Outdated

+                  hints: false
+                },
+                devtool: '#eval-source-map'
+              }

hound bot Sep 12, 2019

Missing semicolon.

templates/tapestry-d3-vue/webpack.config.js Outdated

		@@ -0,0 +1,79 @@
		var path = require('path')
		var webpack = require('webpack')

hound bot Sep 12, 2019

Missing semicolon.

templates/tapestry-d3-vue/webpack.config.js Outdated

		@@ -0,0 +1,79 @@
		var path = require('path')

hound bot Sep 12, 2019

Missing semicolon.

templates/tapestry-d3-vue/src/services/TapestryAPI.js Outdated

+                   */
+                  async updatePermissions(nodeMetaId, permissions) {
+                      try {
+                          const url = `${apiUrl}/tapestries/${this.postId}/nodes/${nodeMetaId}/permissions`;

hound bot Sep 12, 2019

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'template literal syntax' is only available in ES6 (use 'esversion: 6').

templates/tapestry-d3-vue/src/services/TapestryAPI.js Outdated

+                   *
+                   * @return  {Object}
+                   */
+                  async updatePermissions(nodeMetaId, permissions) {

hound bot Sep 12, 2019

Class properties must be methods. Expected '(' but instead saw 'updatePermissions'.
Duplicate class method 'async'.

templates/tapestry-d3-vue/src/services/TapestryAPI.js Outdated

+                  async addLink(link) {
+                      try {
+                          const url = `${apiUrl}/tapestries/${this.postId}/links`;
+                          const response = await axios.post(url, link);

hound bot Sep 12, 2019

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Missing semicolon.

templates/tapestry-d3-vue/src/services/TapestryAPI.js Outdated

+                   */
+                  async addLink(link) {
+                      try {
+                          const url = `${apiUrl}/tapestries/${this.postId}/links`;

hound bot Sep 12, 2019

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'template literal syntax' is only available in ES6 (use 'esversion: 6').

templates/tapestry-d3-vue/src/services/TapestryAPI.js Outdated

+                   *
+                   * @return  {Object}
+                   */
+                  async addLink(link) {

hound bot Sep 12, 2019

Class properties must be methods. Expected '(' but instead saw 'addLink'.
Duplicate class method 'async'.

nandanmen changed the base branch from master to tapestry-d3-vue

September 12, 2019 21:59

wynnset requested changes

View reviewed changes

Collaborator

wynnset left a comment

Please remove any styling-only changes (minimize your changes) to avoid merge conflicts
Please use dashes to separate words in your classes / IDs instead of (double) underscores

wynnset assigned nandanmen


          Reverted style changes and changed class names

717ff11

nandanmen assigned wynnset and unassigned nandanmen

wynnset added 3 commits

September 17, 2019 23:55


          Merge branch 'tapestry-d3-vue' into 111-clean-up-css

a2ddc65


          Visual improvements to add/edit modal

0559a61


          Utilize Bootstrap-Vue components to tidy up add/edit modal even more

e13e8b8

wynnset merged commit c2dddaa into tapestry-d3-vue

wynnset deleted the 111-clean-up-css branch

September 18, 2019 08:47

wynnset mentioned this pull request

Clean up CSS #111

Closed

wynnset pushed a commit that referenced this pull request


          Clean Up Vue Modal Styling (#112)

317b793

* Tidy up add/edit node modal
* Utilize Bootstrap-Vue components to tidy up add/edit modal even more

wynnset pushed a commit that referenced this pull request


          Clean Up Vue Modal Styling (#112)

14927d0

* Tidy up add/edit node modal
* Utilize Bootstrap-Vue components to tidy up add/edit modal even more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment