fix(commandline): error handling

deal with unhandled promise rejections

Author: wyvern8

README.md

@@ -79,7 +79,7 @@ The command line modes and parameters map directly to the functions exposed for
 | ---- | ---------- |
 | getCustomRoles | none |
 | getCustomRole | customRoleKey |
-| createCustomRole | createCustomRole |
+| createCustomRole | customRoleKey, customRoleName, customRolePolicyArray, customRoleDescription(optional) |
 | updateCustomRole | customRoleKey, customRoleName, customRolePolicyArray, customRoleDescription(optional) |
 | upsertCustomRole | customRoleKey, customRoleName, customRolePolicyArray, customRoleDescription(optional) |
 | bulkUpsertCustomRoles | roleBulkLoadFile |

ldutils

@@ -10,7 +10,15 @@ if (!process.env.LAUNCHDARKLY_API_TOKEN) {
 }
 
 let log = console;
+
+// fallback to bunyan logger if debug mode
 if (process.env.LAUNCHDARKLY_API_LOGLEVEL === 'debug') log = undefined;
+
+process.on('unhandledRejection', (reason, p) => {
+    console.error(json.plain({"error": reason}));
+    process.exit(1);
+});
+
 new LaunchDarklyUtils().create(process.env.LAUNCHDARKLY_API_TOKEN, log).then(function(ldUtils) {
 
     program
@@ -119,7 +127,6 @@ new LaunchDarklyUtils().create(process.env.LAUNCHDARKLY_API_TOKEN, log).then(fun
             });
         });
 
-    console.log(process.argv);
     if (process.argv.length < 3) {
         program.help();
         process.exit(1);
@@ -128,8 +135,5 @@ new LaunchDarklyUtils().create(process.env.LAUNCHDARKLY_API_TOKEN, log).then(fun
     program
         .parse(process.argv);
 
-})
-.catch(function(e) {
-    console.log(json.plain(e));
 });
 

src/LaunchDarklyUtilsRoles.js

@@ -18,15 +18,7 @@ export class LaunchDarklyUtilsRoles {
     }
 
     async getCustomRole(customRoleKey) {
-        let that = this;
-        return this.apiClient.apis[this.API_GROUP]
-            .getCustomRole({
-                customRoleKey: customRoleKey
-            })
-            .catch(e => {
-                that.log.error(e);
-                throw e;
-            });
+        return this.apiClient.apis[this.API_GROUP].getCustomRole({ customRoleKey: customRoleKey });
     }
 
     async createCustomRole(customRoleKey, customRoleName, customRolePolicyArray, customRoleDescription) {