Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty output in bash/ip.sh. #334

Merged
merged 3 commits into from Oct 17, 2019

Conversation

@icedream
Copy link
Contributor

commented Oct 1, 2019

This pull request is merely a quick fix for the Bash IP read-out script, replacing the cut call with awk. This allows the script to be more tolerant with indenting spaces.

@wzhouwzhou

This comment has been minimized.

Copy link
Owner

commented Oct 1, 2019

I am unable to reach the original author of the file, Mohammed Nisham; out of respect, would you mind renaming this as a new file, such as icedream_ip.sh?

Copy link
Owner

left a comment

(Please see above request about renaming to icedream_ip.sh)

Original version generated empty output due to `cut` being
whitespace-intolerant.
@icedream icedream force-pushed the icedream:pr/bash/ip/fix branch from b25caad to 0722da8 Oct 2, 2019
@icedream

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

Can't find a way to respond to your review anymore but I have done the requested changes now. :)

@wzhouwzhou wzhouwzhou added this to In progress in Hacktoberfest 2019 via automation Oct 2, 2019
@wzhouwzhou wzhouwzhou moved this from In progress to Reviewer approved in Hacktoberfest 2019 Oct 4, 2019
Hacktoberfest 2019 automation moved this from Reviewer approved to Review in progress Oct 17, 2019
Hacktoberfest 2019 automation moved this from Review in progress to Reviewer approved Oct 17, 2019
Hacktoberfest 2019 automation moved this from Reviewer approved to Review in progress Oct 17, 2019
Hacktoberfest 2019 automation moved this from Review in progress to Reviewer approved Oct 17, 2019
@kannagikazuko kannagikazuko merged commit 84f731a into wzhouwzhou:master Oct 17, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Hacktoberfest 2019 automation moved this from Reviewer approved to Done Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.