New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in search.js #83

Closed
SeraphRoy opened this Issue Jan 20, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@SeraphRoy
Copy link

SeraphRoy commented Jan 20, 2019

At https://github.com/wzpan/hexo-theme-freemind/blob/master/source/js/search.js#L102

var match_content = content.substr(start, end);

I think it should be content.substring as the arguments for substr are start and length and the onces for substring are start and end. Not sure why this is undiscovered for so long as it makes a huge difference when I use it..

wzpan added a commit that referenced this issue Jan 23, 2019

@wzpan

This comment has been minimized.

Copy link
Owner

wzpan commented Jan 23, 2019

You are right. I've fixed it.
Indeed I don't used hexo-generator-search myself because I'm still using hexo 2.x rather than hexo 3.x.
I forked my version of hexo 2.x and have done a lot of customizations so I'm not willing to upgrade to 3.x.

@SeraphRoy

This comment has been minimized.

Copy link
Author

SeraphRoy commented Jan 23, 2019

I see.. Yeah a simple fix should be good enough.

@SeraphRoy SeraphRoy closed this Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment