ClassAliasingMapper itemTypeAsAttribute never works. #28

Closed
patelm5 opened this Issue Oct 6, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@patelm5

patelm5 commented Oct 6, 2015

I'm pretty sure this can never work, whatever it's intended purpose ( I was trying to create a Shortname class mapper which still respected the aliases. )

public boolean itemTypeAsAttribute(final Class<?> clazz) { return classToName.containsKey(clazz); }

The keys in the map are String type.

@joehni

This comment has been minimized.

Show comment
Hide comment
@joehni

joehni Oct 6, 2015

Member

Thanks for heads-up. Fortunately the method is never called, it's a left-over of an old implementation.

Member

joehni commented Oct 6, 2015

Thanks for heads-up. Fortunately the method is never called, it's a left-over of an old implementation.

@joehni joehni added the bug label Oct 6, 2015

@joehni joehni added this to the 1.4.x milestone Oct 6, 2015

@joehni joehni self-assigned this Oct 6, 2015

joehni added a commit that referenced this issue Oct 9, 2015

Fix #28, deprecate ClassAliaslingMapper.itemTypeAsAttributes(Class) and
ClassAliaslingMapper.aliasIsAttribute(String).

@joehni joehni closed this in adcd808 Oct 9, 2015

@joehni joehni modified the milestones: 1.4.x, 1.4.9 Mar 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment