Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance degradation through ImplicitCollectionMapper #61

Closed
purnhar opened this issue Aug 3, 2016 · 2 comments

Comments

@purnhar
Copy link
Contributor

commented Aug 3, 2016

After upgrading from XStream 1.4.8 to 1.4.9 i observed a huge degradation of the performance for XML (un-)marshalling. XStream suddenly got 50-100% slower.
I created a sampling with VisualVM. In my opinion the reason for the perfomance degradation is the new code for the fix "Implicit collection declaration is erroneously inherited or propagated to hidden field of same name." in the class ImplicitCollectionMapper. This fix leads to massive calls to Class.getDeclaredField, which is extremly expensive.

Would it be a possible, to cache the results of the getDeclaredField call or do you have any other idea for a performance optimization? I implemented a caching solution in the pull request #60 .

joehni added a commit that referenced this issue Aug 15, 2016
inheritance of an implicit declared collection, array or map. Closes #60
and #61.
@joehni joehni added the bug label Aug 16, 2016
@joehni joehni added this to the 1.4.x milestone Aug 16, 2016
@joehni joehni self-assigned this Aug 16, 2016
@joehni

This comment has been minimized.

Copy link
Member

commented Aug 16, 2016

Uses cache of ReflectionProvider now.

joehni added a commit that referenced this issue Nov 2, 2016
inheritance of an implicit declared collection, array or map. Closes #60
and #61.
@joehni

This comment has been minimized.

Copy link
Member

commented Nov 2, 2016

Applied to v-1,4,x branch and master.

@joehni joehni closed this Nov 2, 2016
joehni added a commit that referenced this issue Nov 6, 2016
joehni added a commit that referenced this issue Nov 6, 2016
@joehni joehni modified the milestones: 1.4.x, 1.4.10 Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.