java.nio.file.Path converter #38

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@aaron13100
Contributor

aaron13100 commented Feb 7, 2016

a java.nio.file.Path converter for enhancement request #33

@aaron13100

This comment has been minimized.

Show comment
Hide comment
@aaron13100

aaron13100 Feb 7, 2016

Contributor

I'm unclear on the Travis CI requirements because, for example, com.thoughtworks.acceptance.LambdaTest clearly requires Java 8.

thanks

Contributor

aaron13100 commented Feb 7, 2016

I'm unclear on the Travis CI requirements because, for example, com.thoughtworks.acceptance.LambdaTest clearly requires Java 8.

thanks

@joehni

This comment has been minimized.

Show comment
Hide comment
@joehni

joehni Feb 8, 2016

Member

Hi Aaron, thanks for the contribution. You may rewrite the PathConverter using no reflection, it is fine for me, if Travis passes JDK 8+7 builds. I will tweak the Maven build to support the older JDKs (the converter will actually be excluded).

Member

joehni commented Feb 8, 2016

Hi Aaron, thanks for the contribution. You may rewrite the PathConverter using no reflection, it is fine for me, if Travis passes JDK 8+7 builds. I will tweak the Maven build to support the older JDKs (the converter will actually be excluded).

java.nio.file.Path converter.
remove some reflection.
make the jdk 1.6 build work.
@aaron13100

This comment has been minimized.

Show comment
Hide comment
@aaron13100

aaron13100 Feb 8, 2016

Contributor

Great! I've removed the reflection from the converter.

I left it for the call to xstream.alias() though because it creates an alias based on the concrete implementation of java.nio.file.Path (e.g. sun.nio.fs.UnixPath, sun.nio.fs.WindowsFileSystem). I couldn't find a precedent for this in the code.

I couldn't find a way to re-launch the Travis CI builds.

Contributor

aaron13100 commented Feb 8, 2016

Great! I've removed the reflection from the converter.

I left it for the call to xstream.alias() though because it creates an alias based on the concrete implementation of java.nio.file.Path (e.g. sun.nio.fs.UnixPath, sun.nio.fs.WindowsFileSystem). I couldn't find a precedent for this in the code.

I couldn't find a way to re-launch the Travis CI builds.

@joehni joehni added the enhancement label Feb 12, 2016

@joehni joehni added this to the 1.4.x milestone Feb 12, 2016

@joehni joehni self-assigned this Feb 12, 2016

@joehni

This comment has been minimized.

Show comment
Hide comment
@joehni

joehni Feb 13, 2016

Member

Thanks!

Member

joehni commented Feb 13, 2016

Thanks!

@joehni joehni closed this Feb 13, 2016

@joehni joehni modified the milestones: 1.4.9, 1.4.x Mar 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment