Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pop unmarshalled type on exception #91

Closed
wants to merge 1 commit into from

Conversation

@mbakhoff
Copy link

commented Jun 6, 2017

when unmarshal throws an exception then the type is not removed from the stack.
a jenkins specific bug description is available at jenkinsci#2

Märt Bakhoff
@coveralls

This comment has been minimized.

Copy link

commented Jun 6, 2017

Coverage Status

Coverage decreased (-1.9%) to 77.889% when pulling a208f29 on mbakhoff:xstream into 29bb62e on x-stream:master.

@joehni

This comment has been minimized.

Copy link
Member

commented Jun 7, 2017

This has been proposed before, however, it is not valid. XStream is based on an incoming data stream. After an exception the state and location of the pointer in that stream is simply undefined. XStream cannot guarantee anything for the underlying stream especially if a caller wants to continue with the processing of that stream. The raised exception has to quit the complete unmarshalling process and therefore it does not make sense to reset the state of the stack, when the complete object that holds the stack is no longer valid.

@joehni joehni closed this Jun 7, 2017
@joehni joehni added the wontfix label Jun 7, 2017
@mbakhoff

This comment has been minimized.

Copy link
Author

commented Jun 7, 2017

Thanks for the feedback!

@joehni joehni reopened this Jan 30, 2018
@joehni joehni self-assigned this Jan 30, 2018
@joehni joehni added improvement and removed wontfix labels Jan 30, 2018
@joehni joehni added this to the 1.4.x milestone Jan 30, 2018
@joehni joehni closed this in bd71ca4 Feb 3, 2018
joehni added a commit that referenced this pull request Feb 3, 2018
…of exception. Originally provided by Märt Bakhoff. Closes #91 and #106.
@joehni

This comment has been minimized.

Copy link
Member

commented Feb 3, 2018

see #106 for explanation

@joehni joehni modified the milestones: 1.4.x, 1.4.11 Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.