Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize size of string buffer in Base64Encoder #93

Closed

Conversation

@baptistemesta
Copy link
Contributor

commented Jun 28, 2017

In order to avoid the string builder to expand and copy the underlying
char array it uses, it is best to initialize it using an initial size.
This add the initialization of the StrungBuffer with a size calculated
from the input byte array.

In order to avoid the string builder to expand and copy the underlying
char array it uses, it is best to initialize it using an initial size.
This add the initialization of the StrungBuffer with a size calculated
from the input byte array.
@coveralls

This comment has been minimized.

Copy link

commented Jun 28, 2017

Coverage Status

Coverage increased (+0.02%) to 79.782% when pulling 5a13d8e on baptistemesta:fix/perf_base64encode into 29bb62e on x-stream:master.

@joehni joehni self-assigned this Jul 4, 2017
@joehni joehni added the enhancement label Jul 4, 2017
@joehni joehni added this to the 1.4.x milestone Jul 4, 2017
@joehni

This comment has been minimized.

Copy link
Member

commented Jul 29, 2017

Applied. Thanks.

@joehni joehni closed this Jul 29, 2017
@joehni joehni added improvement and removed enhancement labels Jul 30, 2017
@baptistemesta baptistemesta deleted the baptistemesta:fix/perf_base64encode branch Aug 22, 2017
@joehni joehni modified the milestones: 1.4.x, 1.4.11 Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.