Update AdminScoreController.php #25
Conversation
Optimized the SQL query to fetch user information
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
- Coverage 12.24% 12.24% -0.01%
==========================================
Files 19 19
Lines 2523 2524 +1
==========================================
Hits 309 309
- Misses 2214 2215 +1
Continue to review full report at Codecov.
|
| $archiveTable = $lh->getTable("archive", $dbName); | ||
| $loggingTable = $lh->getTable("logging_userindex", $dbName); | ||
| $revisionTable = $lh->getTable("revision_userindex", $dbName); | ||
| $archiveTable = $lh->getTable("archive_userindex", $dbName); |
There was a problem hiding this comment.
You just broke backwards compatibility with all versions of MediaWiki. There's a reason we go through the labs helper - specifically to allow for a table mapping.
That should be documented better on my side, which is a separate issue.
| SELECT 'blocks' as source, COUNT(*) as value FROM $loggingTable l | ||
| INNER JOIN $userTable u ON l.log_user = u.user_id | ||
| WHERE l.log_type='block' AND l.log_action='block' | ||
| AND l.log_namespace=2 AND l.log_deleted=0 AND u.user_name=:username |
There was a problem hiding this comment.
So... you attempt to make this more efficient by adding another Join - which is a slow and heavy process. That makes absolutely no sense.
There was a problem hiding this comment.
Using the "log_user" column in the query makes it better despite adding another join.
There was a problem hiding this comment.
Okay, I'm convinced. Please fix my other comment and we'll give this the thumbs up.
To clarify my other comment - in order to access a table you use the MediaWiki table rather than the labs table. We then map it using app/config/table_map.yml
There was a problem hiding this comment.
👍 from me. The new query definitely runs significantly faster, at around 21.73 sec run time with one test I did. The same test took over 3 minutes with the old query, I just ended up killing it.
Indeed Matthew is right however that we have a table mapping system in place. All you need to know is to pass the normal table name to $lh->getTable
There was a problem hiding this comment.
I am not sure what you mean. Is there any chance you can make the necessary changes?
There was a problem hiding this comment.
Sure. I'll merge then fix it up.
Thank you for this pull request 😄
Optimized the SQL query to fetch user information