New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to improve Scrutinizer score #63

Merged
merged 1 commit into from Jul 28, 2017

Conversation

Projects
None yet
3 participants
@MusikAnimal
Member

MusikAnimal commented Jul 25, 2017

No description provided.

@codecov-io

This comment has been minimized.

codecov-io commented Jul 25, 2017

Codecov Report

Merging #63 into master will increase coverage by 0.01%.
The diff coverage is 39.13%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #63      +/-   ##
=========================================
+ Coverage   18.19%   18.2%   +0.01%     
=========================================
  Files          32      32              
  Lines        3936    3928       -8     
=========================================
- Hits          716     715       -1     
+ Misses       3220    3213       -7
Impacted Files Coverage Δ
src/Xtools/EditCounterRepository.php 0% <ø> (ø) ⬆️
src/AppBundle/Helper/AutomatedEditsHelper.php 100% <ø> (ø) ⬆️
src/AppBundle/Controller/TopEditsController.php 15.03% <ø> (+0.22%) ⬆️
src/Xtools/PagesRepository.php 0% <ø> (ø) ⬆️
src/AppBundle/Controller/ApiController.php 11.82% <ø> (+0.12%) ⬆️
src/AppBundle/Twig/AppExtension.php 43.84% <ø> (ø) ⬆️
src/AppBundle/Controller/MetaController.php 0% <ø> (ø) ⬆️
src/Xtools/Edit.php 62.36% <ø> (ø) ⬆️
src/AppBundle/Twig/WikiExtension.php 38.88% <ø> (-3.22%) ⬇️
src/Xtools/User.php 74.66% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeecdf0...c3b09a1. Read the comment docs.

Attempt to improve Scrutinizer score
Remove unused legacy files

@MusikAnimal MusikAnimal changed the title from [WIP] Attempt to improve Scrutinizer score to Attempt to improve Scrutinizer score Jul 28, 2017

@MusikAnimal MusikAnimal requested review from samwilson and Matthewrbowker and removed request for samwilson Jul 28, 2017

@Matthewrbowker

Looks good!

@Matthewrbowker Matthewrbowker merged commit cced22f into master Jul 28, 2017

5 checks passed

Scrutinizer 5 new issues, 1 updated code elements
Details
codecov/patch 39.13% of diff hit (target 18.19%)
Details
codecov/project 18.2% (+0.01%) compared to eeecdf0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Matthewrbowker Matthewrbowker deleted the scrutinizer branch Jul 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment