New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lang-exists check to also be ucfirst #69

Merged
merged 1 commit into from Jul 27, 2017

Conversation

Projects
None yet
3 participants
@samwilson
Member

samwilson commented Jul 27, 2017

The list returned by getAllLangs has ucfirst language names, so
we do the same here when checking for support of the current
language.

Bug: https://phabricator.wikimedia.org/T171815

Fix lang-exists check to also be ucfirst
The list returned by getAllLangs has ucfirst language names, so
we do the same here when checking for support of the current
language.

Bug: https://phabricator.wikimedia.org/T171815

@Matthewrbowker Matthewrbowker merged commit ed39524 into master Jul 27, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Matthewrbowker Matthewrbowker deleted the lang-name-T171815 branch Jul 27, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Jul 27, 2017

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   18.66%   18.66%           
=======================================
  Files          33       33           
  Lines        3996     3996           
=======================================
  Hits          746      746           
  Misses       3250     3250
Impacted Files Coverage Δ
src/AppBundle/Twig/AppExtension.php 43.84% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0108e55...8855f00. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment