New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sound broken in demo? #1055
Comments
Here is related background: #773 |
Here is a build which retries playing until successfull, eg. when the user interacts: https://5e84aff60cc298000663822b--x3dom.netlify.com/ It needs enabled='true' for AudioClip. Please give it a try. I think it would be safe to adopt the fix. |
Did that change help ? If so I can merge it. |
@npolys Any luck with the sound fix ? |
I'm getting
when I try that build with my scene. Is "netlify" a typo? To answer my own question, I get the same error with |
Sorry, I should have been more explicit. Try: https://5e84aff60cc298000663822b--x3dom.netlify.app/x3dom-full.debug.js |
This build works while the release build doesn't. Now when I click on Floops the animation and the audio start. One time after a reload the audio was out of sync but I couldn't reproduce after several more attempts. Why isn't audio enabled when the startTime is set via an event? For now I've set |
Thanks for the confirmation. It turns out startTime is not implemented. I do not know why. Perhaps because it would require an additional check at each tick. You may be able to route the isActive event from the TouchSensor to AudioClip via a BooleanFilter (since enabling should happen on isActive = false). |
If startTime was implemented then I think my sample would have just worked. The sensor click should have both satisfied the browser's user interaction requirement and by setting the AudioClip's startTime started playback. I will file an issue. |
When will this fix appear in www.x3dom.org/x3dom/release? |
It is already available at https://x3dom.org/download/dev/ Not sure what the plans for a new release are. |
https://examples.x3dom.org/example/x3dom_comic.xhtml
.... would an .mp3 be played ??
The text was updated successfully, but these errors were encountered: