New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve text quality #543

Merged
merged 24 commits into from Sep 8, 2015

Conversation

Projects
None yet
2 participants
@andreasplesch
Contributor

andreasplesch commented Sep 6, 2015

by oversampling by a factor of two but keeping the textured rectangle the same size. Addresses issue #541 . It would be straightforward to make the oversampling factor a custom field of the text node (default 1 or 2) for backwards compatibility.

@mlimper

This comment has been minimized.

Contributor

mlimper commented Sep 7, 2015

Nice, thanks - I would agree to your proposal of making this a custom field of the text node.
Could you add the field before we merge this one?

@andreasplesch

This comment has been minimized.

Contributor

andreasplesch commented Sep 7, 2015

Will do. I would prefer to set the default for this custom field ('quality') to 2. I cannot think of a case where the larger texture would be a problem, and it does look much better. Any reason not to set it to 2 ?
I will also bracket the max. to 10 to avoid extremely large textures. And the min. to 0.5.

@andreasplesch

This comment has been minimized.

Contributor

andreasplesch commented Sep 7, 2015

I added a 'quality' field to the FontStyle node with a default of 2.0 and enforced bracketing to 0.5 and 10. FontStyle seemed more appropriate than Text since it really is a style option. I updated the two examples referenced in issue #541 to use the custom quality factors. Let me know if there is anything else.

@mlimper

This comment has been minimized.

Contributor

mlimper commented Sep 8, 2015

That's great, thanks a lot for this contribution.

mlimper pushed a commit that referenced this pull request Sep 8, 2015

Max Limper
Merge pull request #543 from andreasplesch/text_work
improve text quality ('quality' field in FontStyle for oversampling)

@mlimper mlimper merged commit be941e5 into x3dom:master Sep 8, 2015

@andreasplesch

This comment has been minimized.

Contributor

andreasplesch commented Sep 8, 2015

Glad to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment