Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Autocomments only on CIP" #1383

Closed
justanotheranonymoususer opened this issue Dec 17, 2016 · 1 comment
Closed

Improve "Autocomments only on CIP" #1383

justanotheranonymoususer opened this issue Dec 17, 2016 · 1 comment
Labels
enhancement The issue requests an enhancement to an existing feature.

Comments

@justanotheranonymoususer
Copy link
Contributor

I want to have autocomments for things which are not likely to change, such as references to the memory section. Example:

lea r8,qword ptr ds:[7FF77BE6B560] ; [7FF77BE6B560] = "hello"

On the other hand, I don't want to have autocomments for things which are temporary, such as registers. Example:

mov rcx,rsi ; rsi = "world"

The reason is that by having a register hold a pointer to a string, the whole disassembly changes without a good reason.

@mrexodia mrexodia added the enhancement The issue requests an enhancement to an existing feature. label Dec 17, 2016
@mrexodia
Copy link
Member

While I do agree with your point about this behavior being weird (it has annoyed me a few times as well), the only actual reason for the 'Autocomments on CIP' option is to speed up disassembly. I will see how to change this, probably it's easy enough to make it both performant and behave in an intuitive way...

mrexodia added a commit that referenced this issue Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue requests an enhancement to an existing feature.
Projects
None yet
Development

No branches or pull requests

2 participants