New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase size of path strings #1746

Open
torusrxxx opened this Issue Oct 6, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@torusrxxx
Member

torusrxxx commented Oct 6, 2017

Windows measures the length of path in UTF-16, but x64dbg only allocates MAX_PATH-sized buffer in UTF-8. Since a Unicode character can be larger than 1 byte, this has caused crashes of x64dbg.

@mrexodia mrexodia added the enhancement label Oct 6, 2017

@mrexodia

This comment has been minimized.

Show comment
Hide comment
@mrexodia

mrexodia Oct 6, 2017

Member

will be quite hard because it's hardcoded in a bunch of places...

Member

mrexodia commented Oct 6, 2017

will be quite hard because it's hardcoded in a bunch of places...

@danilaml

This comment has been minimized.

Show comment
Hide comment
@danilaml

danilaml Oct 8, 2017

Contributor

Also, path can be longer than legacy MAX_PATH, though not sure if it's easily fixable.

Contributor

danilaml commented Oct 8, 2017

Also, path can be longer than legacy MAX_PATH, though not sure if it's easily fixable.

@torusrxxx

This comment has been minimized.

Show comment
Hide comment
@torusrxxx

torusrxxx Oct 11, 2017

Member

x64dbg cannot debug a folder, so that shouldn't be an issue. MAX_PATH * 3 is a safe choice since a 4-byte UTF8 character is encoded as 2 UTF16 characters.

Member

torusrxxx commented Oct 11, 2017

x64dbg cannot debug a folder, so that shouldn't be an issue. MAX_PATH * 3 is a safe choice since a 4-byte UTF8 character is encoded as 2 UTF16 characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment