New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confused disassembler #2013

Open
tathanhdinh opened this Issue Aug 31, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@tathanhdinh

tathanhdinh commented Aug 31, 2018

I'm playing with the code base of x64dbg, there are many things that make me surprise, e.g. get Capstone but return Zydis:

const Zydis & CapstoneTokenizer::GetCapstone() const
{
    return _cp;
}

I believe that is because of some previous decision about using Capstone, then changed to use Zydis. Should we refactor these codes?

@mrexodia

This comment has been minimized.

Show comment
Hide comment
@mrexodia

mrexodia Aug 31, 2018

Member

Yes, I think it is a good idea to refactor this.

Member

mrexodia commented Aug 31, 2018

Yes, I think it is a good idea to refactor this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment