New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context menu doesn't account for cursor position #2030

Open
twifty opened this Issue Sep 19, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@twifty

twifty commented Sep 19, 2018

While working within the CPU view, I often add comments and label function calls. I do this mainly using the mouses right click to open the context menu. The problem is when right clicking on a line which is not currently selected/highlighted, the functionality of the context menu applies to the actually selected line.

For example:

1  push 0x0
2  push 0x100
3  call 0xdeadbeef

If line 1 is highlighted, right clicking line 3 and adding a comment will add the comment to line 1 rather than the expected line 3. Similarly, when trying to label the function on line 3, the address will not be listed in the label sub menu.

A work around is to left click the line to select it then right click to open the menu.

A solution would be to also select the line upon a right click.

@mrexodia

This comment has been minimized.

Show comment
Hide comment
@mrexodia

mrexodia Sep 19, 2018

Member
Member

mrexodia commented Sep 19, 2018

@twifty

This comment has been minimized.

Show comment
Hide comment
@twifty

twifty Sep 19, 2018

Fair enough. How about an option to toggle 'right click select'?

twifty commented Sep 19, 2018

Fair enough. How about an option to toggle 'right click select'?

@mrexodia

This comment has been minimized.

Show comment
Hide comment
@mrexodia

mrexodia Sep 19, 2018

Member
Member

mrexodia commented Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment