Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph&Switch&BranchTable #2261

Open
Paliha opened this issue Dec 8, 2019 · 1 comment
Open

Graph&Switch&BranchTable #2261

Paliha opened this issue Dec 8, 2019 · 1 comment
Labels

Comments

@Paliha
Copy link

@Paliha Paliha commented Dec 8, 2019

HI!
Very good analysis of a function or procedure, but not enough of a couple of goodies.
No block size for instructions.
Why is there no code coverage for "case:"?
//jmp ptr [index * sizeof(duint) + switchTable] - I have never met
ok. Why not mov reg, dword ptr [index * sizeof(duint) + switchTable]?
After all, one of the features of such a constructor is jump_reg. And the pointer to the table is very often very close.

And if not difficult, add to the structure "FunctionInfo", total size of all instructions

@mrexodia

This comment has been minimized.

Copy link
Member

@mrexodia mrexodia commented Jan 16, 2020

The issue with detecting jump tables properly is that it requires heuristics that are very error prone. I think developing these is a bit out of scope for x64dbg, but I will keep this open in case somebody would like to pick it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.