Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkeys should not be exclusive to one action in Shortcuts UI #2286

Open
Danatobob opened this issue Feb 5, 2020 · 1 comment
Open

Hotkeys should not be exclusive to one action in Shortcuts UI #2286

Danatobob opened this issue Feb 5, 2020 · 1 comment
Labels

Comments

@Danatobob
Copy link

@Danatobob Danatobob commented Feb 5, 2020

Debugger version: Jan 16 2020
Operating system version: Windows 8.1 Pro 64bit
Selected translation: English

Hi. I've tried to debug using x32dbg for the first time and I wasn't able to copy anything to clipboard when using "CTRL+C" or "CTRL+Ins" on the field shown below (img taken from #2110):
1

Now I've found this - #2110 and it started to make sense - I assume before making "Copy Line" hotkey customizable, it used CTRL+C by default. Now CTRL+C does nothing on default settings for that field which I think is counter-intuitive as any user would expect that to put at least something to clipboard considering other textboxes process CTRL+C just fine (for example "Copy Selected Lines").
What's worse is that I can't assign CTRL+C to "Copy Line" without removing hotkey from "Copy" action in Shortcuts list. So I have to choose: either I keep "Copy" as CTRL+C and not be able to copy anything using CTRL+C from the mentioned textbox or I only use CTRL+C on that textbox and need to assign some non-standard hotkey for "Copy".
The solution I see is to make hotkeys nonexclusive, so that more than one action can have it. This is how it works right now anyway: "Copy value" in registers have CTRL+C, "Copy selected lines" have CTRL+C, etc., so I guess this is more of a Shortcuts UI change than internal rework.

So, to sum it all:

  • Hotkeys should be nonexclusive (looks like just Shortcuts UI rework)
  • "Copy Line" should have CTRL+C hotkey on default settings

P.S. Initially I commented on #2110 but this should be viewed as a new issue i guess.

@mrexodia

This comment has been minimized.

Copy link
Member

@mrexodia mrexodia commented Feb 13, 2020

Hm, in theory you should be able to use Ctrl+C for multiple actions as long as those actions are not both used in the same control. It might be quite challenging to implement this feature in the shortcuts UI though, perhaps a warning could simply be displayed that a hotkey is used multiple times?

You can try if things work as expected by manually modifying the INI (set both ActionCopy and ActionCopyLine to Ctrl+C)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.