Add symbolic name of the breakpoint to be edited, resolves #1326 #1346

Merged
merged 3 commits into from Dec 5, 2016

Projects

None yet

3 participants

@ner0x652
Contributor
ner0x652 commented Dec 4, 2016 edited

This change is Reviewable

src/gui/Src/Gui/EditBreakpointDialog.cpp
@@ -15,7 +16,8 @@ EditBreakpointDialog::EditBreakpointDialog(QWidget* parent, const BRIDGEBP & bp)
}
else
{
- setWindowTitle(QString(tr("Edit Breakpoint %1")).arg(ToHexString(bp.addr)));
+ DisassemblerGraphView disGraphView;
@mrexodia
mrexodia Dec 5, 2016 Member

I think it might be a better idea to copy/paste the getSymbolicName function or make it static because instantiating a DisassemblerGraphView might lead to unpredictable issues.

@ner0x652
ner0x652 Dec 5, 2016 Contributor

Ok, I've made a new pull request with getSymbolicName copied into MiscUtils.

@torusrxxx
Member
@ner0x652
Contributor
ner0x652 commented Dec 5, 2016

@torusrxxx @mrexodia I am agree with the idea of a global function instead of what is in the pull request. I'll change it.

@mrexodia mrexodia merged commit d55494b into x64dbg:development Dec 5, 2016
@mrexodia
Member
mrexodia commented Dec 5, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment