Disassembler copying and statusbar enhancements #1363

Merged
merged 4 commits into from Dec 13, 2016

Projects

None yet

3 participants

@ThunderCls
Contributor
ThunderCls commented Dec 12, 2016 edited
  • Statusbar message update on disassembly data copy (Issue #1280)
  • Extended info on statusbar (like in dump window) of selected
    instructions in the disassembly window
  • Copy multiselected Addreses(VA/RVA) in the disassembly window

This change is Reviewable

@ThunderCls ThunderCls Disassembler copying and statusbar enhancements
- Statusbar message update on disassembly data copy (Issue #1280)
- Extended info on statusbar (like in dump window) of selected
instructions in the disassembly window
- Copy multiselected Addreses(VA/RVA) in the disassembly window
d547b42
@mudlord
mudlord commented Dec 12, 2016

Any chance of copying labels for jumps when copying the disassembly? (to allow for easy MASM/NASM formatting)

And notification if copying jumps which reach outside the selected region to be copied?

@ThunderCls
Contributor

@mrexodia feel free to keep just what you think it's worthy or nothing if that's the case, np whatsoever ;)

@ThunderCls
Contributor

@mudlord the first feature I guess it could be helpful, but for the second one, I don't really see any good use for that

@mrexodia
Member

@mudlord you can use multimate assembler to copy labels automatically...

src/gui/Src/Gui/CPUDisassembly.h
@@ -169,6 +170,7 @@ public slots:
MenuBuilder* mMenuBuilder;
MenuBuilder* mHighlightMenuBuilder;
bool mHighlightContextMenu = false;
+ const char *clipMsg = "The data has been copied to clipboard!\r\n";
@mrexodia
mrexodia Dec 12, 2016 Member

All looks good, except that clipMsg is not translated, however this is inconsistent with the other views where no status bar message is snown...

@ThunderCls
ThunderCls Dec 12, 2016 Contributor

I guess you're right, so the thing would be to just drop off this feature or to make it consistent...which one would it be?

@mrexodia
mrexodia Dec 12, 2016 Member

For me the copy notification has no use but you could add it in Bridge::CopyToClipboard I guess...

ThunderCls added some commits Dec 12, 2016
@ThunderCls ThunderCls clipboard message translated
- "copied to clipboard" message in statusbar is translated and made
globally consistent
cd56701
@ThunderCls ThunderCls Merge remote-tracking branch 'refs/remotes/x64dbg/development' into d…
…evelopment
49668e1
src/gui/Src/Bridge/Bridge.cpp
@@ -33,6 +33,7 @@ void Bridge::CopyToClipboard(const QString & text)
{
QClipboard* clipboard = QApplication::clipboard();
clipboard->setText(text);
+ GuiAddStatusBarMessage(QT_TRANSLATE_NOOP("DBG", "The data has been copied to clipboard.\n"));
@mrexodia
mrexodia Dec 12, 2016 Member

This will not translate it 😄 The correct way is tr("The data has been copied to clipboard.\n").toUtf8().constData()

@ThunderCls
ThunderCls Dec 13, 2016 Contributor

So dumb of me, right? thanks...ready

@mrexodia mrexodia merged commit 8da5df6 into x64dbg:development Dec 13, 2016
@mrexodia
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment