Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Replace disassembler engine with Zydis #1730
Future work required
If there's anything you don't like that you'd like me to change, just say the word.
- While at it, added branch info logic to disassembler class - Thus reduce direct checks by mnemonic in GUI and analysis code - Replaced direct disassembler struct access with disassembler class calls where trivially possible - Removed workarounds for empty segment registers - Temp. disabled `cbInstrCapstone` command - Temp. disabled flag stuff in `QBeaEngine`
I think it was one of his coworkers actually...…
On Mon, 9 Oct 2017 at 02:03, Joel Höner ***@***.***> wrote: The Mergings project card mentions that @blaquee <https://github.com/blaquee> found problems with this PR. Could you elaborate? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1730 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWCmRCQsP3D6uVovrlLf7z-6A4lwf7Pks5sqWLHgaJpZM4PjR4a> .
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.