Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

表情判断逻辑仍有漏洞 #286

Closed
xaoxuu opened this issue Apr 22, 2020 · 20 comments
Closed

表情判断逻辑仍有漏洞 #286

xaoxuu opened this issue Apr 22, 2020 · 20 comments
Labels

Comments

@xaoxuu
Copy link
Contributor

xaoxuu commented Apr 22, 2020

If you want to report a bug, please provide the following information:

输入下面的格式就不会显示表情

表情:测试1 :smile:

建议增加一对符号来判断,双冒号太容易误判了。

例如:

[:smile:]

或者:

(:smile:)
@MHuiG
Copy link

MHuiG commented Apr 22, 2020

@xCss 昨天有日语大佬过来改我的翻译,你看看顺便把你的翻译也给改了。

https://github.com/MiniValine/minivaline-i18n/blob/master/ja-JP/index.json

目前还有阿拉伯大佬给出了阿拉伯语的建议,你看看要不要考虑加进去

https://github.com/MiniValine/minivaline-i18n/blob/master/ar-SA/index.json

@Reqwey
Copy link

Reqwey commented Apr 22, 2020

应该学习MiniValine的判断逻辑, 如!(:抖眼.gif:)

@Reqwey
Copy link

Reqwey commented Apr 22, 2020

括号外面再加特殊字符

@xCss xCss added the bug label Apr 23, 2020
@Reqwey
Copy link

Reqwey commented Apr 23, 2020

而且评论时写行内代码, 即``时表情也会失效

@MHuiG
Copy link

MHuiG commented Apr 24, 2020

而且评论时写行内代码, 即 ``时表情也会失效

Valine专业测试团队
0450

@Reqwey
Copy link

Reqwey commented Apr 25, 2020

哦对了, 显然连输两个https:开头的网址也会报错

反正用冒号很不靠谱啦

@MHuiG
Copy link

MHuiG commented Apr 25, 2020

哦对了, 显然连输两个https:开头的网址也会报错

反正用冒号很不靠谱啦

然而Github这个评论框就用了冒号 🚀 💯

:rocket:

@Reqwey
Copy link

Reqwey commented Apr 25, 2020

哦对了, 显然连输两个https:开头的网址也会报错
反正用冒号很不靠谱啦

然而Github这个评论框就用了冒号 🚀

:rocket:

那你可以用正则搞一下, 如果出现非法字符(标点符号, 空格和大写字母)就不判断为emoji

@Reqwey
Copy link

Reqwey commented Apr 25, 2020

还有, 我换Gitalk了

@MHuiG
Copy link

MHuiG commented Apr 25, 2020

还有, 我换Gitalk了

Gitalk 国内网络不稳定,我从Gitalk换到Valine 最后自己搞了一套MiniValine,最近换主题感觉MV和主题不搭又换回Valine,哈哈~

@Reqwey
Copy link

Reqwey commented Apr 25, 2020

还有, 我换Gitalk了

Gitalk 国内网络不稳定,我从Gitalk换到Valine 最后自己搞了一套MiniValine,最近换主题感觉MV和主题不搭又换回Valine,哈哈~

http://googlehelper.net/

@MHuiG
Copy link

MHuiG commented Apr 25, 2020

还有, 我换Gitalk了

Gitalk 国内网络不稳定,我从Gitalk换到Valine 最后自己搞了一套MiniValine,最近换主题感觉MV和主题不搭又换回Valine,哈哈~

http://googlehelper.net/

Got it!!

@xaoxuu
Copy link
Contributor Author

xaoxuu commented Apr 25, 2020

gitalk太慢了,而且最老的评论排序在最上面,几年过去了还这样……

@MHuiG
Copy link

MHuiG commented Apr 25, 2020

gitalk太慢了,而且最老的评论排序在最上面,几年过去了还这样……

gitalk代码是开源的,给gitalk作者提Issue 发PR

https://github.com/gitalk/gitalk

@Reqwey
Copy link

Reqwey commented Apr 25, 2020

@xaoxuu 你的主题是自带Gitalk吗? 我能不能手动用npm更新

@Reqwey
Copy link

Reqwey commented Apr 25, 2020

gitalk太慢了,而且最老的评论排序在最上面,几年过去了还这样……

没有啊, 默认最新的在最上面, 可以选的 https://blog.lhkstudio.me/about/
image.png
记得清除缓存, 不然你看到的是Valine🤣

@MHuiG
Copy link

MHuiG commented Apr 25, 2020

还有, 我换Gitalk了

Gitalk 国内网络不稳定,我从Gitalk换到Valine 最后自己搞了一套MiniValine,最近换主题感觉MV和主题不搭又换回Valine,哈哈~

因安全漏洞现已换回Gitalk,成功回到起点

5150

和Valine作者道别,近期不会再来了,说真的还有点不舍。

5000

最后,膜拜大佬。

祝大家身体健康, 疫情早日结束.

@xCss
Copy link
Owner

xCss commented Apr 25, 2020

v1.4.10 已修复,感谢反馈

@xCss xCss closed this as completed Apr 25, 2020
@Reqwey
Copy link

Reqwey commented Apr 25, 2020

👍那我是不是又要换回来了

@MHuiG
Copy link

MHuiG commented Apr 26, 2020

👍那我是不是又要换回来了

等漏洞补上再换吧

#298

PS:Gitalk 网络报错太不靠谱了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants