add publication page and commit other fixes #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added individual images and shifted content of the pages.
The home page now contains the lab logo in the background. The lab welcome message has been centered to the bottom of the screen. The extra sections from the people page have been commented currently. The Projects page has been updated with official funded projects.
Addressed the following issues - 1. **Add Publication Page (Closes #7)**: - Created a new publication page using Quarto with references sourced from a BibTeX file. - Publications are dynamically generated and sorted by year. - This addresses the feature request to create a structured, accessible, and dynamically updated publication list. 2. **Fix Issue Report Page URL Contains a Tag (Closes #6)**: - Resolved the issue where the "Report an Issue" link in the footer included an erroneous `<a>` tag in the `_quarto.yml` file. - The link is now properly formatted, without the tag, and directs users to the correct issue reporting page on GitHub. 3. **Add Alt Text to Headshots in People Page (Closes #5)**: - Added descriptive alt text to all headshots on the "People" page to improve accessibility. - Ensures that screen readers can properly interpret the images, enhancing accessibility for users with visual impairments. 4. The link colour issue has also been resolved.
jooyoungseo
requested changes
Sep 6, 2024
Member
jooyoungseo
left a comment
jooyoungseo
left a comment
There was a problem hiding this comment.
LGTM! Please resolve the merge conflicts.
Collaborator
Author
|
I have resolved merge conflicts. Please merge if you think it ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the following issues and implements the necessary fixes:
Add Publication Page (Closes feat: add publication page #7):
Fix Issue Report Page URL Contains a Tag (Closes fix: address an issue where issue report page URI contains a tag #6):
<a>tag in the_quarto.ymlfile.Add Alt Text to Headshots in People Page (Closes fix(people): add alt text to headshot #5):
Fixed footer link colour issue as well.