Find url in a new way #56
Conversation
Pull Request Test Coverage Report for Build 119
💛 - Coveralls |
| : $mime =~ m{video/3gp;} ? '3gp' | ||
| : 'flv' | ||
| ; | ||
| } |
There was a problem hiding this comment.
Would https://metacpan.org/pod/MIME::Type help here? Specifically subType()?
t/youtube.t
Outdated
| check_video_fetch_url('Y1I1KcKvz9Q'); | ||
|
|
||
| # YAPC video 2 | ||
| # YAPC video 2 |
There was a problem hiding this comment.
Thanks for fixing the line endings here. Do any of the examples in this test trigger _is_new()? It would be helpful to cover both cases. This test will only be run if P5_YOUTUBE_NETWORK_TESTS, so we don't have to worry about the average test case for the end user.
There was a problem hiding this comment.
t/data/player_response.html is trimmed from curl -o ... the first YAPC video. Getting the old content as a test might be a challenge.
kiwiroy
force-pushed
the
new-find-urls
branch
2 times, most recently
from
227bb87
to
ef68dbb
Compare
| return 1 unless ($args->{fmt_list} and $args->{url_encoded_fmt_stream_map}); | ||
| return 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
I suppose we could add a very simple unit test for this as well, to ensure that it is covered.
| @@ -578,6 +622,8 @@ Parses given URL and returns playlist ID. | |||
|
|
|||
| Parses given URL and returns YouTube username. | |||
|
|
|||
| =item B<get_video_id($video_id)> | |||
|
I just switched to GitHub workflows. Could you delete |
also pass CI additional test of new path
|
Rebased and all green. |
|
This is now on CPAN. |
This fixes #55, although I'm unsure how long this fix will be successful.
There's some ancillary toolchain/linting edits included so that Travis has a green light - hope that's ok.
