Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulled PR/10 by @ryochin. #50

Closed
wants to merge 1 commit into from

Conversation

@manwar
Copy link
Contributor

commented Oct 6, 2019

Hi @oalders

Please review the PR.
It just rebase the PR/10 by @ryochin.

Many Thanks.
Best Regards,
Mohammad S Anwar

@oalders
oalders approved these changes Oct 6, 2019
Copy link
Collaborator

left a comment

Thanks @manwar!

Test failures are not related to this change.

@oalders

This comment has been minimized.

Copy link
Collaborator

commented Oct 6, 2019

I cherry-picked and amended the commit so that the original author would get more clear credit for the work. So, I'll close this PR unmerged, since the commit is now in master. Thanks again for taking the time to do this, @manwar. 💯

@oalders oalders closed this Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.