New substitution variable {user} #7

Merged
merged 3 commits into from Feb 9, 2013

2 participants

@isync

I've added code to extract the YouTube username as well, so anyone using this here can add info about the video owner (or uploader) to downloaded videos. Also, added some preliminary test code for that.

Again, thumbs up, xaicron, for giving us all a Perl alternative to youtube-dl!

isync added some commits Jan 21, 2013
@isync isync Update lib/WWW/YouTube/Download.pm
Added that the YouTube video user is parsed out and offered as yet another substitution variable in file naming.
1750e69
@isync isync Create video_user.t
Added tests for parsing out of YT user(names), untested, meant as a starting point.
6e1e57f
@xaicron
Owner

Thanks a patch. But, t/private/video_user.t is broken. Please fix it.

@isync isync Update t/private/video_user.t
Was a mock up, now works.
Also: we should ask users if it is okay to connect to the Internet for testing!
917384c
@isync

Done.
Please add a prompt() to the Build.PL to ask users if it is okay to connect to the Internet / YouTube server for testing...

@xaicron xaicron merged commit 3bf3d2a into xaicron:master Feb 9, 2013
@xaicron
Owner

Okay. However, if the video was deleted then test will be fail...
I will change the test cases that parse static HTML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment