From e2ee8dc11e8a6a03292a15cd95329bb83963611c Mon Sep 17 00:00:00 2001
From: Matthew Leibowitz <mattleibow@live.com>
Date: Tue, 8 May 2018 18:47:01 +0200
Subject: [PATCH 1/3] Update the docs with the latest APIs

---
 .../xamarin-essentials-android.xml            |  2 +-
 .../xamarin-essentials-ios.xml                |  5 +-
 .../xamarin-essentials-uwp.xml                |  2 +-
 .../en/FrameworksIndex/xamarin-essentials.xml |  2 +-
 docs/en/Xamarin.Essentials/Locale.xml         | 34 +++++-----
 docs/en/Xamarin.Essentials/SecureStorage.xml  | 68 +++++++++++++++++++
 6 files changed, 92 insertions(+), 21 deletions(-)

diff --git a/docs/en/FrameworksIndex/xamarin-essentials-android.xml b/docs/en/FrameworksIndex/xamarin-essentials-android.xml
index 4e74a9ce5..417b003a1 100644
--- a/docs/en/FrameworksIndex/xamarin-essentials-android.xml
+++ b/docs/en/FrameworksIndex/xamarin-essentials-android.xml
@@ -207,9 +207,9 @@
     </Type>
     <Type Name="Xamarin.Essentials.Locale" Id="T:Xamarin.Essentials.Locale">
       <Member Id="P:Xamarin.Essentials.Locale.Country" />
+      <Member Id="P:Xamarin.Essentials.Locale.Id" />
       <Member Id="P:Xamarin.Essentials.Locale.Language" />
       <Member Id="P:Xamarin.Essentials.Locale.Name" />
-      <Member Id="P:Xamarin.Essentials.Locale.Id" />
     </Type>
     <Type Name="Xamarin.Essentials.Location" Id="T:Xamarin.Essentials.Location">
       <Member Id="M:Xamarin.Essentials.Location.#ctor" />
diff --git a/docs/en/FrameworksIndex/xamarin-essentials-ios.xml b/docs/en/FrameworksIndex/xamarin-essentials-ios.xml
index 31d985b0f..8cd262658 100644
--- a/docs/en/FrameworksIndex/xamarin-essentials-ios.xml
+++ b/docs/en/FrameworksIndex/xamarin-essentials-ios.xml
@@ -207,9 +207,9 @@
     </Type>
     <Type Name="Xamarin.Essentials.Locale" Id="T:Xamarin.Essentials.Locale">
       <Member Id="P:Xamarin.Essentials.Locale.Country" />
+      <Member Id="P:Xamarin.Essentials.Locale.Id" />
       <Member Id="P:Xamarin.Essentials.Locale.Language" />
       <Member Id="P:Xamarin.Essentials.Locale.Name" />
-      <Member Id="P:Xamarin.Essentials.Locale.Id" />
     </Type>
     <Type Name="Xamarin.Essentials.Location" Id="T:Xamarin.Essentials.Location">
       <Member Id="M:Xamarin.Essentials.Location.#ctor" />
@@ -337,7 +337,10 @@
     </Type>
     <Type Name="Xamarin.Essentials.SecureStorage" Id="T:Xamarin.Essentials.SecureStorage">
       <Member Id="M:Xamarin.Essentials.SecureStorage.GetAsync(System.String)" />
+      <Member Id="M:Xamarin.Essentials.SecureStorage.GetAsync(System.String,Security.SecAccessible)" />
       <Member Id="M:Xamarin.Essentials.SecureStorage.SetAsync(System.String,System.String)" />
+      <Member Id="M:Xamarin.Essentials.SecureStorage.SetAsync(System.String,System.String,Security.SecAccessible)" />
+      <Member Id="P:Xamarin.Essentials.SecureStorage.DefaultAccessible" />
     </Type>
     <Type Name="Xamarin.Essentials.SensorSpeed" Id="T:Xamarin.Essentials.SensorSpeed">
       <Member Id="F:Xamarin.Essentials.SensorSpeed.Fastest" />
diff --git a/docs/en/FrameworksIndex/xamarin-essentials-uwp.xml b/docs/en/FrameworksIndex/xamarin-essentials-uwp.xml
index 846c3db42..25047b73e 100644
--- a/docs/en/FrameworksIndex/xamarin-essentials-uwp.xml
+++ b/docs/en/FrameworksIndex/xamarin-essentials-uwp.xml
@@ -207,9 +207,9 @@
     </Type>
     <Type Name="Xamarin.Essentials.Locale" Id="T:Xamarin.Essentials.Locale">
       <Member Id="P:Xamarin.Essentials.Locale.Country" />
+      <Member Id="P:Xamarin.Essentials.Locale.Id" />
       <Member Id="P:Xamarin.Essentials.Locale.Language" />
       <Member Id="P:Xamarin.Essentials.Locale.Name" />
-      <Member Id="P:Xamarin.Essentials.Locale.Id" />
     </Type>
     <Type Name="Xamarin.Essentials.Location" Id="T:Xamarin.Essentials.Location">
       <Member Id="M:Xamarin.Essentials.Location.#ctor" />
diff --git a/docs/en/FrameworksIndex/xamarin-essentials.xml b/docs/en/FrameworksIndex/xamarin-essentials.xml
index 37fedf73b..d804a830a 100644
--- a/docs/en/FrameworksIndex/xamarin-essentials.xml
+++ b/docs/en/FrameworksIndex/xamarin-essentials.xml
@@ -207,9 +207,9 @@
     </Type>
     <Type Name="Xamarin.Essentials.Locale" Id="T:Xamarin.Essentials.Locale">
       <Member Id="P:Xamarin.Essentials.Locale.Country" />
+      <Member Id="P:Xamarin.Essentials.Locale.Id" />
       <Member Id="P:Xamarin.Essentials.Locale.Language" />
       <Member Id="P:Xamarin.Essentials.Locale.Name" />
-      <Member Id="P:Xamarin.Essentials.Locale.Id" />
     </Type>
     <Type Name="Xamarin.Essentials.Location" Id="T:Xamarin.Essentials.Location">
       <Member Id="M:Xamarin.Essentials.Location.#ctor" />
diff --git a/docs/en/Xamarin.Essentials/Locale.xml b/docs/en/Xamarin.Essentials/Locale.xml
index 9696eb75f..a3613e13f 100644
--- a/docs/en/Xamarin.Essentials/Locale.xml
+++ b/docs/en/Xamarin.Essentials/Locale.xml
@@ -33,10 +33,10 @@
         <remarks>This value may vary between platforms.</remarks>
       </Docs>
     </Member>
-    <Member MemberName="Language">
-      <MemberSignature Language="C#" Value="public string Language { get; }" />
-      <MemberSignature Language="ILAsm" Value=".property instance string Language" />
-      <MemberSignature Language="DocId" Value="P:Xamarin.Essentials.Locale.Language" />
+    <Member MemberName="Id">
+      <MemberSignature Language="C#" Value="public string Id { get; }" />
+      <MemberSignature Language="ILAsm" Value=".property instance string Id" />
+      <MemberSignature Language="DocId" Value="P:Xamarin.Essentials.Locale.Id" />
       <MemberType>Property</MemberType>
       <AssemblyInfo>
         <AssemblyName>Xamarin.Essentials</AssemblyName>
@@ -46,15 +46,15 @@
         <ReturnType>System.String</ReturnType>
       </ReturnValue>
       <Docs>
-        <summary>Language name or code.</summary>
+        <summary>Unique Id of the Locale.</summary>
         <value></value>
-        <remarks>This value may vary between platforms.</remarks>
+        <remarks></remarks>
       </Docs>
     </Member>
-    <Member MemberName="Name">
-      <MemberSignature Language="C#" Value="public string Name { get; }" />
-      <MemberSignature Language="ILAsm" Value=".property instance string Name" />
-      <MemberSignature Language="DocId" Value="P:Xamarin.Essentials.Locale.Name" />
+    <Member MemberName="Language">
+      <MemberSignature Language="C#" Value="public string Language { get; }" />
+      <MemberSignature Language="ILAsm" Value=".property instance string Language" />
+      <MemberSignature Language="DocId" Value="P:Xamarin.Essentials.Locale.Language" />
       <MemberType>Property</MemberType>
       <AssemblyInfo>
         <AssemblyName>Xamarin.Essentials</AssemblyName>
@@ -64,15 +64,15 @@
         <ReturnType>System.String</ReturnType>
       </ReturnValue>
       <Docs>
-        <summary>Display name of the Locale.</summary>
+        <summary>Language name or code.</summary>
         <value></value>
-        <remarks></remarks>
+        <remarks>This value may vary between platforms.</remarks>
       </Docs>
     </Member>
-     <Member MemberName="Id">
-      <MemberSignature Language="C#" Value="public string Id { get; }" />
-      <MemberSignature Language="ILAsm" Value=".property instance string Id" />
-      <MemberSignature Language="DocId" Value="P:Xamarin.Essentials.Locale.Id" />
+    <Member MemberName="Name">
+      <MemberSignature Language="C#" Value="public string Name { get; }" />
+      <MemberSignature Language="ILAsm" Value=".property instance string Name" />
+      <MemberSignature Language="DocId" Value="P:Xamarin.Essentials.Locale.Name" />
       <MemberType>Property</MemberType>
       <AssemblyInfo>
         <AssemblyName>Xamarin.Essentials</AssemblyName>
@@ -82,7 +82,7 @@
         <ReturnType>System.String</ReturnType>
       </ReturnValue>
       <Docs>
-        <summary>Unique Id of the Locale.</summary>
+        <summary>Display name of the Locale.</summary>
         <value></value>
         <remarks></remarks>
       </Docs>
diff --git a/docs/en/Xamarin.Essentials/SecureStorage.xml b/docs/en/Xamarin.Essentials/SecureStorage.xml
index ec0070afa..445f41f0d 100644
--- a/docs/en/Xamarin.Essentials/SecureStorage.xml
+++ b/docs/en/Xamarin.Essentials/SecureStorage.xml
@@ -29,6 +29,24 @@
     </remarks>
   </Docs>
   <Members>
+    <Member MemberName="DefaultAccessible">
+      <MemberSignature Language="C#" Value="public static Security.SecAccessible DefaultAccessible { get; set; }" />
+      <MemberSignature Language="ILAsm" Value=".property valuetype Security.SecAccessible DefaultAccessible" />
+      <MemberSignature Language="DocId" Value="P:Xamarin.Essentials.SecureStorage.DefaultAccessible" />
+      <MemberType>Property</MemberType>
+      <AssemblyInfo>
+        <AssemblyName>Xamarin.Essentials</AssemblyName>
+        <AssemblyVersion>1.0.0.0</AssemblyVersion>
+      </AssemblyInfo>
+      <ReturnValue>
+        <ReturnType>Security.SecAccessible</ReturnType>
+      </ReturnValue>
+      <Docs>
+        <summary>To be added.</summary>
+        <value>To be added.</value>
+        <remarks>To be added.</remarks>
+      </Docs>
+    </Member>
     <Member MemberName="GetAsync">
       <MemberSignature Language="C#" Value="public static System.Threading.Tasks.Task&lt;string&gt; GetAsync (string key);" />
       <MemberSignature Language="ILAsm" Value=".method public static hidebysig class System.Threading.Tasks.Task`1&lt;string&gt; GetAsync(string key) cil managed" />
@@ -51,6 +69,30 @@
         <remarks></remarks>
       </Docs>
     </Member>
+    <Member MemberName="GetAsync">
+      <MemberSignature Language="C#" Value="public static System.Threading.Tasks.Task&lt;string&gt; GetAsync (string key, Security.SecAccessible accessible);" />
+      <MemberSignature Language="ILAsm" Value=".method public static hidebysig class System.Threading.Tasks.Task`1&lt;string&gt; GetAsync(string key, valuetype Security.SecAccessible accessible) cil managed" />
+      <MemberSignature Language="DocId" Value="M:Xamarin.Essentials.SecureStorage.GetAsync(System.String,Security.SecAccessible)" />
+      <MemberType>Method</MemberType>
+      <AssemblyInfo>
+        <AssemblyName>Xamarin.Essentials</AssemblyName>
+        <AssemblyVersion>1.0.0.0</AssemblyVersion>
+      </AssemblyInfo>
+      <ReturnValue>
+        <ReturnType>System.Threading.Tasks.Task&lt;System.String&gt;</ReturnType>
+      </ReturnValue>
+      <Parameters>
+        <Parameter Name="key" Type="System.String" />
+        <Parameter Name="accessible" Type="Security.SecAccessible" />
+      </Parameters>
+      <Docs>
+        <param name="key">To be added.</param>
+        <param name="accessible">To be added.</param>
+        <summary>To be added.</summary>
+        <returns>To be added.</returns>
+        <remarks>To be added.</remarks>
+      </Docs>
+    </Member>
     <Member MemberName="SetAsync">
       <MemberSignature Language="C#" Value="public static System.Threading.Tasks.Task SetAsync (string key, string value);" />
       <MemberSignature Language="ILAsm" Value=".method public static hidebysig class System.Threading.Tasks.Task SetAsync(string key, string value) cil managed" />
@@ -75,5 +117,31 @@
         <remarks></remarks>
       </Docs>
     </Member>
+    <Member MemberName="SetAsync">
+      <MemberSignature Language="C#" Value="public static System.Threading.Tasks.Task SetAsync (string key, string value, Security.SecAccessible accessible);" />
+      <MemberSignature Language="ILAsm" Value=".method public static hidebysig class System.Threading.Tasks.Task SetAsync(string key, string value, valuetype Security.SecAccessible accessible) cil managed" />
+      <MemberSignature Language="DocId" Value="M:Xamarin.Essentials.SecureStorage.SetAsync(System.String,System.String,Security.SecAccessible)" />
+      <MemberType>Method</MemberType>
+      <AssemblyInfo>
+        <AssemblyName>Xamarin.Essentials</AssemblyName>
+        <AssemblyVersion>1.0.0.0</AssemblyVersion>
+      </AssemblyInfo>
+      <ReturnValue>
+        <ReturnType>System.Threading.Tasks.Task</ReturnType>
+      </ReturnValue>
+      <Parameters>
+        <Parameter Name="key" Type="System.String" />
+        <Parameter Name="value" Type="System.String" />
+        <Parameter Name="accessible" Type="Security.SecAccessible" />
+      </Parameters>
+      <Docs>
+        <param name="key">To be added.</param>
+        <param name="value">To be added.</param>
+        <param name="accessible">To be added.</param>
+        <summary>To be added.</summary>
+        <returns>To be added.</returns>
+        <remarks>To be added.</remarks>
+      </Docs>
+    </Member>
   </Members>
 </Type>

From 7b6efde011abe3309adbf091f61868cad0680e86 Mon Sep 17 00:00:00 2001
From: James Montemagno <james.montemagno@gmail.com>
Date: Fri, 11 May 2018 09:39:20 -0700
Subject: [PATCH 2/3] Add docs for SecAccessible

---
 docs/en/Xamarin.Essentials/SecureStorage.xml | 42 ++++++++++++--------
 1 file changed, 26 insertions(+), 16 deletions(-)

diff --git a/docs/en/Xamarin.Essentials/SecureStorage.xml b/docs/en/Xamarin.Essentials/SecureStorage.xml
index 445f41f0d..dda3bc099 100644
--- a/docs/en/Xamarin.Essentials/SecureStorage.xml
+++ b/docs/en/Xamarin.Essentials/SecureStorage.xml
@@ -16,7 +16,7 @@
       <para>Each platform uses the platform provided native API's for storing data securely:</para>
       <list type="bullet">
         <item>
-          <term>iOS: Data is stored in KeyChain.</term>
+          <term>iOS: Data is stored in KeyChain. Additional information on SecAccessible at: <see cref="https://developer.xamarin.com/api/type/Security.SecAccessible/" /></term>
         </item>
         <item>
           <term>Android: Encryption keys are stored in KeyStore and encrypted data is stored in a named shared preference container (PackageId.Xamarin.Essentials).</term>
@@ -42,9 +42,9 @@
         <ReturnType>Security.SecAccessible</ReturnType>
       </ReturnValue>
       <Docs>
-        <summary>To be added.</summary>
-        <value>To be added.</value>
-        <remarks>To be added.</remarks>
+        <summary>iOS: Default SecAccessible to use for all Get/Set calls to KeyChain. Default value is AfterFirstUnlock.</summary>
+        <value>The SecAccessible to use for all KeyChain access.</value>
+        <remarks>For more information see: <see cref="https://developer.xamarin.com/api/type/Security.SecAccessible/" /></remarks>
       </Docs>
     </Member>
     <Member MemberName="GetAsync">
@@ -66,7 +66,9 @@
         <param name="key">Storage Key.</param>
         <summary>Gets the decrypted value for a given Key.</summary>
         <returns>Decrypted string.</returns>
-        <remarks></remarks>
+        <remarks>
+          <para></para>
+        </remarks>
       </Docs>
     </Member>
     <Member MemberName="GetAsync">
@@ -86,11 +88,13 @@
         <Parameter Name="accessible" Type="Security.SecAccessible" />
       </Parameters>
       <Docs>
-        <param name="key">To be added.</param>
-        <param name="accessible">To be added.</param>
-        <summary>To be added.</summary>
-        <returns>To be added.</returns>
-        <remarks>To be added.</remarks>
+        <param name="key">Storage Key.</param>
+        <param name="accessible">SecAccessible for iOS to use</param>
+        <summary>Gets the decrypted value for a given Key. iOS override to specify SecAccessible for the KeyChain.</summary>
+        <returns>iOS: Default SecAccessible to use for all Get/Set calls to KeyChain. Default value is AfterFirstUnlock.</returns>
+        <remarks>
+          <para />
+        </remarks>
       </Docs>
     </Member>
     <Member MemberName="SetAsync">
@@ -113,8 +117,12 @@
         <param name="key">Storage Key.</param>
         <param name="value">The value to be encrypted.</param>
         <summary>Stores the value which is encrypted, for a given Key.</summary>
-        <returns></returns>
-        <remarks></remarks>
+        <returns>
+          <para></para>
+        </returns>
+        <remarks>
+          <para></para>
+        </remarks>
       </Docs>
     </Member>
     <Member MemberName="SetAsync">
@@ -135,12 +143,14 @@
         <Parameter Name="accessible" Type="Security.SecAccessible" />
       </Parameters>
       <Docs>
-        <param name="key">To be added.</param>
+        <param name="key">Storage Key.</param>
         <param name="value">To be added.</param>
         <param name="accessible">To be added.</param>
-        <summary>To be added.</summary>
-        <returns>To be added.</returns>
-        <remarks>To be added.</remarks>
+        <summary>Stores the value which is encrypted, for a given Key. iOS override to specify SecAccessible for the KeyChain.</summary>
+        <returns>Stores the value which is encrypted, for a given Key. iOS override to specify SecAccessible for the KeyChain.</returns>
+        <remarks>
+          <para></para>
+        </remarks>
       </Docs>
     </Member>
   </Members>

From 226c36169dda02247a544deb0af9f26daadfe14d Mon Sep 17 00:00:00 2001
From: Matthew Leibowitz <mattleibow@live.com>
Date: Sat, 12 May 2018 13:17:37 +0200
Subject: [PATCH 3/3] Update SecureStorage.xml

---
 docs/en/Xamarin.Essentials/SecureStorage.xml | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/docs/en/Xamarin.Essentials/SecureStorage.xml b/docs/en/Xamarin.Essentials/SecureStorage.xml
index dda3bc099..554fa274a 100644
--- a/docs/en/Xamarin.Essentials/SecureStorage.xml
+++ b/docs/en/Xamarin.Essentials/SecureStorage.xml
@@ -91,10 +91,10 @@
         <param name="key">Storage Key.</param>
         <param name="accessible">SecAccessible for iOS to use</param>
         <summary>Gets the decrypted value for a given Key. iOS override to specify SecAccessible for the KeyChain.</summary>
-        <returns>iOS: Default SecAccessible to use for all Get/Set calls to KeyChain. Default value is AfterFirstUnlock.</returns>
-        <remarks>
-          <para />
-        </remarks>
+        <returns>
+          <para></para>
+        </returns>
+        <remarks>iOS: Default SecAccessible to use for all Get/Set calls to KeyChain. Default value is AfterFirstUnlock.</remarks>
       </Docs>
     </Member>
     <Member MemberName="SetAsync">
@@ -144,10 +144,12 @@
       </Parameters>
       <Docs>
         <param name="key">Storage Key.</param>
-        <param name="value">To be added.</param>
+        <param name="value">The value to be encrypted.</param>
         <param name="accessible">To be added.</param>
         <summary>Stores the value which is encrypted, for a given Key. iOS override to specify SecAccessible for the KeyChain.</summary>
-        <returns>Stores the value which is encrypted, for a given Key. iOS override to specify SecAccessible for the KeyChain.</returns>
+        <returns>
+          <para></para>
+        </returns>
         <remarks>
           <para></para>
         </remarks>