Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ColorConverters.GetCompliment() method #970

Merged
merged 7 commits into from Nov 16, 2019
Merged

Add ColorConverters.GetCompliment() method #970

merged 7 commits into from Nov 16, 2019

Conversation

mrlacey
Copy link
Contributor

@mrlacey mrlacey commented Nov 4, 2019

Description of Change

Add ability to easily get a complimentary color to the ColorConverters class.

No samples added as nothing else in this [helper] class has samples.

Bugs Fixed

API Changes

Added:

  • public static Color GetCompliment(Color original)

Behavioral Changes

none

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@VSC-Service-Account

This comment has been minimized.

@mrlacey
Copy link
Contributor Author

mrlacey commented Nov 4, 2019

Notes on build failure

Please follow instructions here which may help to resolve issue.

The here mentioned above is to a location (https://review.docs.microsoft.com/en-us/help/onboard/faq?branch=master) that I don't have access to.

  • The Details links in the table listing issues don't go anywhere useful.

  • _dependentPackages/ECMA2Yaml/tools/Run.ps1 and .openpublishing.publish.config.json do not contain any changes by me and have nothing specific to the changes I've made.

  • The build report contains errors and warnings related to things I haven't changed. This looks like an issue unrelated to my PR and so don't know what I can do to address the problem myself.

Advice on what (if anything) I can do to address the above will be appreciated.

@Redth
Copy link
Member

Redth commented Nov 12, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@VSC-Service-Account

This comment has been minimized.

@jamesmontemagno
Copy link
Collaborator

@praeclarum any thoughts on this? I know you did a bunch of color compliment stuff on Continuous.

@VSC-Service-Account

This comment has been minimized.

@VSC-Service-Account

This comment has been minimized.

@praeclarum
Copy link

Yeah, this converts the color to its opposite hue. Pretty standard and useful in a jiffy.

This does not provide dark/light compliments like Continuous has, just the hue compliment.

@jamesmontemagno
Copy link
Collaborator

@praeclarum do you think the name is appropriate?

@jamesmontemagno jamesmontemagno added this to the 1.4.0 milestone Nov 15, 2019
@VSC-Service-Account

This comment has been minimized.

@jamesmontemagno jamesmontemagno merged commit 34110b5 into xamarin:master Nov 16, 2019
@attrib75
Copy link

attrib75 commented Nov 20, 2019

Idea: This thread is a great example of how the community can see how things get built at MS and what the process is so that we may feel less intimidated by it and contribute more. It would be awesome if you guys made a video touching on the kinds of things that happened here. PR > build pipelines > checkins, dicusssions, approval, merge, etc. Maybe you already do and I'm not aware of it. Example: 'Validation Status Passed' validation wha? You triggered some tests? '@jamesmontemagno approved these changes' what does that mean? (I know this may seem trivial to most of you but in the community it is not)

@mrlacey mrlacey deleted the i957-ComplimentaryColor branch November 20, 2019 20:40
nickrandolph pushed a commit to builttoroam/Essentials that referenced this pull request Dec 4, 2019
* Add ColoConverter.GetCompliment method

+ tests & docs
For xamarin#957

* Add ColoConverter.GetCompliment method

+ tests & docs
For xamarin#957

* Update index files
@vividos
Copy link
Contributor

vividos commented Dec 9, 2019

I'm not a native English speaker, but I'm pretty sure Compliment is not the correct term, is complement or complementary.
Ah, here's a page explaining the difference: https://www.lawlessenglish.com/english-mistakes/complement-vs-compliment/

@jamesmontemagno
Copy link
Collaborator

Great catch! I think Complementary is correct to use :)

@mrlacey
Copy link
Contributor Author

mrlacey commented Dec 11, 2019

@jamesmontemagno should I open a new issue for the rename or will you reopen the original one for this PR (#957)

As this hasn't yet made it into a release, I assume there's no issue with updating the method name.

@jamesmontemagno
Copy link
Collaborator

Feel free to open a new PR :) I opened an issue for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants