New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ColorConverters.GetCompliment()
method
#970
Add ColorConverters.GetCompliment()
method
#970
Conversation
This comment has been minimized.
This comment has been minimized.
Notes on build failure
The here mentioned above is to a location (https://review.docs.microsoft.com/en-us/help/onboard/faq?branch=master) that I don't have access to.
Advice on what (if anything) I can do to address the above will be appreciated. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
@praeclarum any thoughts on this? I know you did a bunch of color compliment stuff on Continuous. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Yeah, this converts the color to its opposite hue. Pretty standard and useful in a jiffy. This does not provide dark/light compliments like Continuous has, just the hue compliment. |
@praeclarum do you think the name is appropriate? |
This comment has been minimized.
This comment has been minimized.
Idea: This thread is a great example of how the community can see how things get built at MS and what the process is so that we may feel less intimidated by it and contribute more. It would be awesome if you guys made a video touching on the kinds of things that happened here. PR > build pipelines > checkins, dicusssions, approval, merge, etc. Maybe you already do and I'm not aware of it. Example: 'Validation Status Passed' validation wha? You triggered some tests? '@jamesmontemagno approved these changes' what does that mean? (I know this may seem trivial to most of you but in the community it is not) |
* Add ColoConverter.GetCompliment method + tests & docs For xamarin#957 * Add ColoConverter.GetCompliment method + tests & docs For xamarin#957 * Update index files
I'm not a native English speaker, but I'm pretty sure Compliment is not the correct term, is complement or complementary. |
Great catch! I think Complementary is correct to use :) |
@jamesmontemagno should I open a new issue for the rename or will you reopen the original one for this PR (#957) As this hasn't yet made it into a release, I assume there's no issue with updating the method name. |
Feel free to open a new PR :) I opened an issue for it |
Description of Change
Add ability to easily get a complimentary color to the ColorConverters class.
No samples added as nothing else in this [helper] class has samples.
Bugs Fixed
API Changes
Added:
public static Color GetCompliment(Color original)
Behavioral Changes
none
PR Checklist