Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bindings for Account Kit #19

Closed
bholmes opened this issue Sep 8, 2016 · 8 comments
Closed

Add Bindings for Account Kit #19

bholmes opened this issue Sep 8, 2016 · 8 comments

Comments

@bholmes
Copy link
Contributor

bholmes commented Sep 8, 2016

Add iOS and Android binding libraries for Facebook's Account Kit

@aamiranwar001
Copy link

Hi, when we have a Facebook Account Kit library for Xamarin.iOS and Xamarin.Android?

@rudacs
Copy link

rudacs commented Jul 18, 2017

Nothing yet?

@S1r-Lanzelot
Copy link
Contributor

S1r-Lanzelot commented Mar 15, 2018

OK - so obviously this is still needed and some people want it, including myself. Is there any work done towards this enhancement, if so how is it coming? If not, was it determined this would not be worth binding - if so, why?

If it just a matter of man hours - how can myself/community help to get this going? Does someone just need to start a branch on creating the bindings and start working towards these bindings via https://docs.microsoft.com/en-us/xamarin/android/platform/binding-java-library/ and https://docs.microsoft.com/en-us/xamarin/ios/platform/binding-objective-c/ ?

Thanks

@Redth
Copy link
Member

Redth commented Mar 21, 2018

@S1r-Lanzelot this is not a high priority item for us at this time. We would definitely welcome pull requests to add bindings for these libraries. We just ask that you follow the existing file structure and build script patterns we have in place in the repository :)

@S1r-Lanzelot
Copy link
Contributor

@Redth , thanks for your reply, I'm working on this now so I'll be sure to submit a PR with the proper structure/scripts when I am happy with it. Android / iOS may be staggered depending on my time.

@S1r-Lanzelot
Copy link
Contributor

S1r-Lanzelot commented Apr 19, 2018

@Redth and @bholmes - please review the PRs for closing out this issue (adding Account Kit for both iOS and Android).... Feedback would be greatly appreciated.

#61
#63

Thanks.

@Redth
Copy link
Member

Redth commented Apr 19, 2018

Thanks, it's definitely on my short list! Will be looking at them very soon.

@S1r-Lanzelot
Copy link
Contributor

This issue can now be closed.

@bholmes bholmes closed this as completed Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants