New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google MobileAds / Bad BaseType for the SearchRequest interface #5

Closed
scordonnier opened this Issue May 18, 2016 · 3 comments

Comments

Projects
None yet
2 participants

@SotoiGhost SotoiGhost self-assigned this May 18, 2016

@SotoiGhost

This comment has been minimized.

Show comment
Hide comment
@SotoiGhost

SotoiGhost May 19, 2016

Member

Hi @scordonnier.

Thanks for leaving a sample code and the solution too in Xamarin Forums, I'll review the code and, if everything looks ok, I'll apply the solution.

Member

SotoiGhost commented May 19, 2016

Hi @scordonnier.

Thanks for leaving a sample code and the solution too in Xamarin Forums, I'll review the code and, if everything looks ok, I'll apply the solution.

SotoiGhost added a commit to SotoiGhost/GoogleApisForiOSComponents that referenced this issue May 20, 2016

[fix][mobileads] Fix Issue #5
- Changed SearchRequest BaseType from NSObject to Request class
- Added missing Fluid AdSize constant
@SotoiGhost

This comment has been minimized.

Show comment
Hide comment
@SotoiGhost

SotoiGhost May 20, 2016

Member

Waiting for approval of Pull request #7 to fix this issue.

Member

SotoiGhost commented May 20, 2016

Waiting for approval of Pull request #7 to fix this issue.

bholmes added a commit that referenced this issue May 23, 2016

@SotoiGhost SotoiGhost added the bug label May 23, 2016

@SotoiGhost

This comment has been minimized.

Show comment
Hide comment
@SotoiGhost

SotoiGhost May 23, 2016

Member

Pull request #7 accepted, fix will be available on G.MobileAds v7.7.1.1

Member

SotoiGhost commented May 23, 2016

Pull request #7 accepted, fix will be available on G.MobileAds v7.7.1.1

@SotoiGhost SotoiGhost closed this May 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment