Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Frame IsClippedToBound broken on IOS somewhere after 4.6.0.800 #11278

Closed
ish-1313 opened this issue Jul 2, 2020 · 3 comments
Closed

[Bug] Frame IsClippedToBound broken on IOS somewhere after 4.6.0.800 #11278

ish-1313 opened this issue Jul 2, 2020 · 3 comments
Assignees
Labels
a/frame e/2 🕑 2 in-progress This issue has an associated pull request that may resolve it! p/iOS 🍎 t/bug 🐛
Projects

Comments

@ish-1313
Copy link

ish-1313 commented Jul 2, 2020

Description

I have the following code (related part)

    <Grid Padding="0" ColumnSpacing="2" Margin="0,5,0,5" HorizontalOptions="Fill" x:Name="Item">
                           <Grid.ColumnDefinitions>
                               <ColumnDefinition Width="{StaticResource PetImageWidth}"/>
                               <ColumnDefinition Width="*" />
                           </Grid.ColumnDefinitions>
                           <Grid.RowDefinitions>
                               <RowDefinition Height="{StaticResource PetImageHeight}" />
                           </Grid.RowDefinitions>

                           <Frame Grid.Row="0" Grid.Column="0"  IsClippedToBounds="True" CornerRadius="50"   Padding="0" 
                                                  HorizontalOptions="Fill" VerticalOptions="Fill">
                               <Image   Source="{Binding BindingImageSource}" Style="{StaticResource PetImageStyle}"  />
                           </Frame>

which makes rounded image. after upgrading to 4.7.0.968 (same with 4.7.0.1080) I found , that on IOS I am having squared image (on Android ok ).
reverting back to 4.6.0.800 , got rounded image

  • Version with issue:
    at least 4.7.0.968 and 4.7.0.1080
  • Last known good version:
    4.6.0.800
  • IDE:
    Visual studio for Mac 8.6.5.23
    Xamarin.Mac 6.18.0.23 (d16-6 / 088c73638)

Screenshots

image
image

between screenshots only Xamarin.forms nuget package was updated from 4.6.0.800 to 4.7.0.968

@ish-1313 ish-1313 added s/unverified New report that has yet to be verified t/bug 🐛 labels Jul 2, 2020
@pauldipietro pauldipietro added this to New in Triage Jul 2, 2020
@jsuarezruiz
Copy link
Contributor

Could be the same as #11091
In this case, will be fixed by #11129

@jsuarezruiz jsuarezruiz self-assigned this Jul 2, 2020
@jsuarezruiz jsuarezruiz moved this from New to Ready For Work in Triage Jul 2, 2020
@jsuarezruiz jsuarezruiz added e/2 🕑 2 and removed s/unverified New report that has yet to be verified labels Jul 2, 2020
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Jul 2, 2020
@samhouts samhouts added this to In Progress in 4.7.0 Jul 2, 2020
@ish-1313
Copy link
Author

ish-1313 commented Jul 2, 2020

it seems that for quick workaround the easiest way will be to use imagebutton instead frame+image

<!--
  <Frame Grid.Row="0" Grid.Column="0"  IsClippedToBounds="True" CornerRadius="50"   Padding="0" 
                                 HorizontalOptions="Fill" VerticalOptions="Fill">
      <Image   Source="{Binding BindingImageSource}" Style="{StaticResource PetImageStyle}"  />
    </Frame>
      -->
    <ImageButton Grid.Row="0" Grid.Column="0" CornerRadius="50" WidthRequest="100" HeightRequest="100"
                       Source="{Binding BindingImageSource}" IsEnabled="False" Aspect="AspectFill" />

result

image

@samhouts samhouts moved this from In Progress to Done in 4.7.0 Jul 6, 2020
@samhouts samhouts added this to To do in iOS Ready For Work Jul 9, 2020
@samhouts samhouts removed this from Ready For Work in Triage Jul 9, 2020
@samhouts
Copy link
Member

closed by #11129

iOS Ready For Work automation moved this from To do to Done Jul 13, 2020
@samhouts samhouts removed this from Done in iOS Ready For Work Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/frame e/2 🕑 2 in-progress This issue has an associated pull request that may resolve it! p/iOS 🍎 t/bug 🐛
Projects
No open projects
4.7.0
  
Done
Development

No branches or pull requests

3 participants