Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] AndroidDeviceInfo is setting ScaledScreenSize with Width for Height #1579

Closed
adrianknight89 opened this issue Jan 14, 2018 · 4 comments · Fixed by #3641
Closed

Comments

@adrianknight89
Copy link
Contributor

Description

Here's the issue:

ScaledScreenSize = new Size(_pixelScreenSize.Width / _scalingFactor, _pixelScreenSize.Width / _scalingFactor);

When Size is being allocated, we're using Width for Height.

@pauldipietro pauldipietro added this to New in Triage Jan 14, 2018
@adrianknight89 adrianknight89 changed the title [Android] AndroidDeviceInfo is setting ScaledScreenSize with Width for Height [Internal] AndroidDeviceInfo is setting ScaledScreenSize with Width for Height Jan 14, 2018
@StephaneDelcroix StephaneDelcroix added this to Ready in v3.1.0 via automation Jan 15, 2018
@StephaneDelcroix StephaneDelcroix removed this from New in Triage Jan 15, 2018
@samhouts samhouts added this to New in Triage via automation May 10, 2018
@samhouts samhouts removed this from Ready in v3.1.0 May 10, 2018
@samhouts samhouts moved this from New to Ready For Work in Triage May 10, 2018
@samhouts samhouts added the e/1 🕐 1 label Jul 26, 2018
@samhouts samhouts added this to To do in Sprint 140 Aug 11, 2018
@adrianknight89
Copy link
Contributor Author

@rmarinho @hartez #3641 fixes this.

Triage automation moved this from Ready For Work to Closed Aug 23, 2018
Sprint 140 automation moved this from To do to Done Aug 23, 2018
@rmarinho
Copy link
Member

Oh awesome thanks missed it.

@hartez
Copy link
Contributor

hartez commented Aug 27, 2018

Well, now I'm just sad that @adrianknight89 noticed this like 8 months ago, told us about it, and we somehow still missed it. :(

@adrianknight89
Copy link
Contributor Author

@hartez You guys have a lot on your plate, so I'm not surprised. Looks like it'll be tough to scour the current list of issues and mark duplicate items. Thanks for fixing this issue though. :)

@samhouts samhouts removed this from Done in v3.6.0 Sep 21, 2018
@samhouts samhouts added this to In Progress in v3.4.0 Sep 21, 2018
@samhouts samhouts moved this from In Progress to Done in v3.4.0 Sep 21, 2018
@samhouts samhouts removed this from Done in v3.4.0 Nov 19, 2018
@samhouts samhouts added this to In Progress in v3.3.0 Nov 19, 2018
@samhouts samhouts moved this from In Progress to Done in v3.3.0 Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Sprint 140
  
Done
v3.3.0
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants