New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] IsSpellCheckEnabled on Entry/Editor #1660

Closed
hartez opened this Issue Jan 25, 2018 · 4 comments

Comments

Projects
5 participants
@hartez
Copy link
Member

hartez commented Jan 25, 2018

Rationale

The Entry and Editor controls do not have a simple mechanism for disabling the native spell-checking features. For some basic text entry scenarios (e.g., entering a username or editing markup), the spell-checking features provide a negative experience.

Implementation

Add the following BindableProperty to InputView:

public static readonly BindableProperty IsSpellCheckEnabledProperty = 
BindableProperty.Create("IsSpellCheckEnabled", typeof(bool), typeof(Entry)));

The value of IsSpellCheckEnabled should roughly map to UITextField.SpellCheckingType on iOS, FormsTextBox.IsSpellCheckEnabled on UWP, and FormsEditText.IsSuggestionsEnabled on Android.

In situations where the value of IsSpellCheckEnabled would conflict with the selected Keyboard settings (i.e., where spell checking is not a feature offered for the selected keyboard), this value will have no effect.

Backward Compatibility

The renderers for Entry and Editor on each platform should check BindableObject.GetIsDefault(); the behavior of the renderers should only be altered if IsSpellCheckEnabled has been explicitly set. This should provide backward compatibility.

Difficulty: Easy

@hartez

This comment has been minimized.

Copy link
Member Author

hartez commented Jan 25, 2018

This is dependent on #1652.

@hartez hartez added this to Backlog in Enhancements Jan 25, 2018

@hartez hartez changed the title IsSpellCheckEnabled on Entry/Editor [Enhancement] IsSpellCheckEnabled on Entry/Editor Jan 25, 2018

@jassmith jassmith moved this from Backlog to Ready for Implementation in Enhancements Jan 25, 2018

@hartez hartez moved this from Ready for Implementation to Backlog in Enhancements Jan 26, 2018

@jassmith jassmith moved this from Backlog to Ready for Implementation in Enhancements Jan 26, 2018

@jassmith

This comment has been minimized.

Copy link
Contributor

jassmith commented Jan 26, 2018

Looks good, I like the usage of GetIsDefault to avoid backcompat issues. Should go a decent way to making things sane.

We will need to spread that as a general mechanism to be used by all new properties implemented in F100 in order to keep things nice and consistent.

@hartez hartez removed this from New in Triage Jan 29, 2018

@ntherning ntherning self-assigned this Feb 5, 2018

@ntherning ntherning moved this from Ready for Implementation to In Progress in Enhancements Feb 5, 2018

@ravinderjangra

This comment has been minimized.

Copy link
Contributor

ravinderjangra commented Feb 7, 2018

@hartez should it be added in entry and editor both. or we can add in some common interface?

ntherning added a commit to ntherning/Xamarin.Forms that referenced this issue Feb 7, 2018

[Enhancement] IsSpellCheckEnabled on Entry/Editor
Adds the InputView.IsSpellCheckEnabled property which makes it easier to
disable the native spell checking features. Fixes xamarin#1660.

ntherning added a commit to ntherning/Xamarin.Forms that referenced this issue Feb 8, 2018

[Enhancement] IsSpellCheckEnabled on Entry/Editor
Adds the InputView.IsSpellCheckEnabled property which makes it easier to
disable the native spell checking features. Fixes xamarin#1660.

@ntherning ntherning referenced this issue Feb 8, 2018

Merged

[All] IsSpellCheckEnabled on Entry/Editor #1836

4 of 4 tasks complete

ntherning added a commit to ntherning/Xamarin.Forms that referenced this issue Feb 9, 2018

[Enhancement] IsSpellCheckEnabled on Entry/Editor
Adds the InputView.IsSpellCheckEnabled property which makes it easier to
disable the native spell checking features. Fixes xamarin#1660.
@hartez

This comment has been minimized.

Copy link
Member Author

hartez commented Feb 14, 2018

@ravinderjangra InputView is a common ancestor of Entry and Editor, so adding it there would cover both cases.

Enhancements automation moved this from In Progress to Done Feb 16, 2018

rmarinho added a commit that referenced this issue Feb 16, 2018

[Enhancement] IsSpellCheckEnabled on Entry/Editor (#1836)
Adds the InputView.IsSpellCheckEnabled property which makes it easier to
disable the native spell checking features. Fixes #1660.

@samhouts samhouts added this to Done in v3.1.0 May 7, 2018

@samhouts samhouts removed this from Done in Enhancements Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment