Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listview.ItemTapped doesnt fire when viewcell has ContxctAction and GestureRecognizer #2026

Open
bentmar opened this Issue Mar 6, 2018 · 6 comments

Comments

7 participants
@bentmar
Copy link
Contributor

bentmar commented Mar 6, 2018

Description

ItemTapped event is not fired when a viewcell has contextaction + an element that has a gestrurerecognizer.

On earlier versions of 2.5.0 the issue with this combo was that the contextAction fired just by scrolling the screen (should only fire when longtap), the fix for this issue is here #1441.

Now that the fix mentioned is included, Taps doesnt work (with the same combo of viewcell)

Steps to Reproduce

  1. Run Repro (has instructions and is extremely basic)

Expected Behavior

Tapevent should fire

Actual Behavior

Tapevent doesnt fire

Basic Information

  • Version with issue: 2.5.1-pre1
  • Last known good version: 2.4.X
  • IDE: Visual Studio 2017
  • Affected Devices: Android (only tested on android)

Reproduction Link

listtap.zip

@bentmar

This comment has been minimized.

Copy link
Contributor Author

bentmar commented Apr 3, 2018

can we please have some attention on this? would very much like to leave 2.4.X

@davidevosti

This comment has been minimized.

Copy link

davidevosti commented May 8, 2018

bentmar if you want to move to 2.5, XF 2.5.0.122203 is the latest build that doesn't prevent this issue (at least for us)

@wegascee

This comment has been minimized.

Copy link

wegascee commented May 30, 2018

XF 2.5 has another issue (see #1331). Only XF 2.4 worked for me. I hope Xamarin doesn't need one year to fix the issue ...

@swansca79

This comment was marked as off-topic.

Copy link

swansca79 commented Jun 13, 2018

The problem seems to be just with the context actions. If I remove them the ItemTapped/ItemSelected events start firing again. Putting a TapGestureRecognizer around the entire cell is almost a workaround, except that when you long press to get the context actions the TapGestureRecognizer fires also. The only workaround I see is putting some sort of icon to tap, like an arrow if your list view item is going to another page.

This bug has surfaced before in the old bugzilla tool. This type of basic ListView functionality is core to many apps, and the fact that it's not somehow tested by the Xamarin team prior to deploying their product is ridiculous. Every Xamarin Forms release since 2.5 has been borderline unusable because of bugs like this and other problems with ListView grouping. I'm probably preaching to the choir, but when Microsoft is involved, this is what you can expect. It's been that way since the 90's. If I had known this acquisition would have happened some day, I would have never started using Xamarin.

@ChristopherStephan

This comment has been minimized.

Copy link

ChristopherStephan commented Jul 13, 2018

Issue is still present in Xamarin.Forms 3.2.0.871581

@swansca79

This comment was marked as disruptive content.

Copy link

swansca79 commented Jul 13, 2018

Shocker

@samhouts samhouts removed this from Ready For Work in Triage Oct 15, 2018

@samhouts samhouts added the inactive label Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.