Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add IsVisible to ToolbarItem #3838

Open
davidortinau opened this issue Sep 19, 2018 · 17 comments · May be fixed by #8878
Open

[Enhancement] Add IsVisible to ToolbarItem #3838

davidortinau opened this issue Sep 19, 2018 · 17 comments · May be fixed by #8878

Comments

@davidortinau
Copy link
Contributor

@davidortinau davidortinau commented Sep 19, 2018

Rationale

At times you need to check if a toolbar item is visible, and to set it thus.

Related: https://xamarin.uservoice.com/forums/258559/suggestions/15508584

Implementation

Add new properties to Toolbaritem for:

  • IsVisible
@davidortinau davidortinau added the F100 label Sep 19, 2018
@pauldipietro pauldipietro added this to New in Triage Sep 19, 2018
@kingces95 kingces95 removed this from New in Triage Sep 20, 2018
@PureWeen PureWeen changed the title [Enhancement] Add IsVisible and IsEnabled to ToolbarItem [Enhancement] Add IsVisible to ToolbarItem Sep 21, 2018
@AmrAlSayed0

This comment has been minimized.

Copy link

@AmrAlSayed0 AmrAlSayed0 commented Sep 26, 2018

Meanwhile, this is already implemented here by @adamped and Norman Mackay but only on the Xamarin.Froms layer, no renderers.

@samhouts samhouts added this to In Progress in v3.6.0 Oct 1, 2018
@Skirtek

This comment has been minimized.

Copy link

@Skirtek Skirtek commented Jan 25, 2019

Is there any progress? This feature is in progress for about four months :(

@samhouts samhouts removed this from In Progress in v3.6.0 Feb 2, 2019
@samhouts samhouts added this to Under consideration in Enhancements Feb 5, 2019
@samhouts samhouts moved this from Under consideration to Needs Specification in Enhancements Feb 6, 2019
@mackayn

This comment has been minimized.

Copy link

@mackayn mackayn commented Mar 22, 2019

@Skirtek

Adam wrote a little to support toolbar visibility which I modified a bit, it's not perfect but used it in a few apps in an MVVM scenario.

https://forums.xamarin.com/discussion/40622/found-a-way-to-make-toolbaritems-visible-invisible-without-a-custom-renderer

@Skirtek

This comment has been minimized.

Copy link

@Skirtek Skirtek commented Mar 22, 2019

Thanks! I used your code with a little changes. But still waiting for support from Xamarin Team :)

@cmeeren

This comment has been minimized.

Copy link

@cmeeren cmeeren commented Apr 5, 2019

The workaround posted above is not something I can live with, since if the initial state is hidden, the toolbar item still pops up for a second before disappearing. This is confusing to users.

Hoping this will get officially implemented!

@thudugala

This comment has been minimized.

Copy link

@thudugala thudugala commented Apr 24, 2019

Also please add "Font Family" or "File Image Source" for Font Icon support

@mfeingol

This comment has been minimized.

Copy link

@mfeingol mfeingol commented Jun 7, 2019

This would be a great enhancement to ToolbarItem.

@MortMH

This comment has been minimized.

Copy link

@MortMH MortMH commented Jun 28, 2019

I need this as well to remove/add functionality based on account type.

@Skirtek

This comment has been minimized.

Copy link

@Skirtek Skirtek commented Jun 28, 2019

One year anniversary of this issue is coming! ;)

@stesvis

This comment has been minimized.

Copy link

@stesvis stesvis commented Sep 9, 2019

If a regular button can/should be visible or invisible depending on some condition, why assume that a toolbar button should be always visible?

@Skirtek

This comment has been minimized.

Copy link

@Skirtek Skirtek commented Oct 10, 2019

Could you tell us what happend with #3946? Could we expect this feature soon?

@jfversluis

This comment has been minimized.

Copy link
Member

@jfversluis jfversluis commented Oct 11, 2019

@Skirtek from the top of my head the biggest problem, also emerges from the comments in the PR you linked, is that the toolbar items, at least on iOS, simply don't support this. That is why we would need to work around this somehow. But doing that causes a lot of side-effects and other unwanted behavior we cannot predict. I would not hold my breath for seeing this feature very soon. Of course you are welcome to propose a solution and/or open a PR for it.

@burrowj

This comment has been minimized.

Copy link

@burrowj burrowj commented Nov 23, 2019

Would a ZeroWidth option be possible

@muak muak linked a pull request that will close this issue Dec 13, 2019
1 of 2 tasks complete
@muak

This comment has been minimized.

Copy link

@muak muak commented Dec 13, 2019

I tried creating the pull request #8878 for this issue.

@Skirtek

This comment has been minimized.

Copy link

@Skirtek Skirtek commented Dec 13, 2019

@muak I am very glad that the problem will be solved. Congratulations! :)

@samhouts samhouts added this to In Progress in vNext (4.5.0) Dec 13, 2019
@groege

This comment has been minimized.

Copy link

@groege groege commented Dec 20, 2019

Any idea, what Xamarin version will this be available, and when that version will be pushed to nuget?

@jfversluis

This comment has been minimized.

Copy link
Member

@jfversluis jfversluis commented Dec 20, 2019

@groege it's too early to say. The PR is not merged yet. We need to review it and test it first.

My guess now is that it would be part of 4.6, but no guarantees. Keep your eyes on the PR!

@samhouts samhouts added this to In Progress in vNext+1 (master) Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Enhancements
  
Needs Specification
vNext (4.5.0)
  
In Progress
vNext+1 (master)
  
In Progress
You can’t perform that action at this time.