Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bindable Span height Issue #4026

Closed
OmerHmead opened this issue Oct 7, 2018 · 1 comment · Fixed by #4448

Comments

@OmerHmead
Copy link

commented Oct 7, 2018

Description

When trying update span text using binding the text will cut off , if the new label text needs more rows to display

Steps to Reproduce

  1. Open the sample project
  2. Click on the button (to make the bindable span text longer)
  3. Note that the text will cut off

Expected Behavior

The label height should be update and the text shouldn't cut off

Actual Behavior

The bindable span text cut off

Basic Information

  • IDE: Microsoft visual studio 2017 15.8.5
  • Platform Target Frameworks:
    • iOS: 12 simulator
    • Android: 8 device and simulator

Screenshots

Android
android issue
IOS
bindable-ios-span-issue

Reproduction Link

Sample Code
Bindable-Span-Issue.zip

@pauldipietro pauldipietro added this to New in Triage Oct 7, 2018

@samhouts samhouts added this to the 3.2.0 milestone Oct 10, 2018

@samhouts samhouts moved this from New to Ready For Work in Triage Oct 10, 2018

@samhouts samhouts added this to Ready in v3.2.0 Oct 10, 2018

@samhouts samhouts added this to To do in iOS Ready For Work Oct 15, 2018

@samhouts samhouts removed this from Ready For Work in Triage Oct 15, 2018

@samhouts samhouts modified the milestones: 3.2.0, 3.3.0 Oct 18, 2018

@samhouts samhouts removed this from Ready in v3.2.0 Oct 18, 2018

@samhouts samhouts added this to Ready in v3.4.0 Oct 18, 2018

@samhouts samhouts added this to To do in Sprint 144 Oct 31, 2018

@paymicro

This comment has been minimized.

Copy link
Collaborator

commented Nov 14, 2018

Also reproduced in UWP.

@rmarinho rmarinho moved this from To do to In progress in Sprint 144 Nov 15, 2018

@rmarinho rmarinho self-assigned this Nov 15, 2018

@rmarinho rmarinho moved this from In progress to Ready for Review (Issues) in Sprint 144 Nov 16, 2018

@samhouts samhouts added this to In Progress in v3.6.0 Nov 19, 2018

@samhouts samhouts removed this from Ready in v3.4.0 Nov 19, 2018

@samhouts samhouts removed this from In Progress in v3.6.0 Nov 19, 2018

@samhouts samhouts added this to In Progress in v3.6.0 Nov 19, 2018

@samhouts samhouts removed this from In Progress in v3.6.0 Nov 19, 2018

@samhouts samhouts added this to Ready in v3.3.0 Nov 19, 2018

@samhouts samhouts added this to In Progress in v3.6.0 Nov 19, 2018

@samhouts samhouts removed this from In Progress in v3.6.0 Nov 20, 2018

@samhouts samhouts modified the milestones: 3.3.0, 3.4.0 Nov 20, 2018

@samhouts samhouts added this to In Progress in v3.6.0 Nov 20, 2018

@samhouts samhouts removed this from Ready in v3.3.0 Nov 20, 2018

@samhouts samhouts added this to Ready in v3.4.0 Nov 20, 2018

@samhouts samhouts removed this from In Progress in v3.6.0 Nov 20, 2018

@samhouts samhouts added this to In Progress in v3.6.0 Nov 20, 2018

@samhouts samhouts removed this from the 3.4.0 milestone Nov 21, 2018

v3.4.0 automation moved this from Ready to Done Nov 29, 2018

Android Ready For Work automation moved this from To do to Done Nov 29, 2018

iOS Ready For Work automation moved this from To do to Done Nov 29, 2018

rmarinho added a commit that referenced this issue Nov 29, 2018
[Core]Call invalidate measure after the FormattedText is set (#4448) f…
…ixes #4026

* [Controls] Add repo for for issue #4026

* [Controls]Add instructions for issue #4026

* [Core] Hook FormattedTextChanging

* [Core] Invalidate measure after the renderer updates the Control's text

* [iOS] Make sure to clear perfectSize on Font property changing

* [iOS] Fix nre when accessing old or new element

@samhouts samhouts moved this from In Progress to Done in v3.6.0 Nov 29, 2018

@samhouts samhouts removed this from Done in v3.6.0 Jan 3, 2019

@samhouts samhouts added this to In Progress in v3.5.0 Jan 11, 2019

@samhouts samhouts moved this from In Progress to Done in v3.5.0 Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.