New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] remove sealed from Span #4083

Closed
MichaelRumpler opened this Issue Oct 15, 2018 · 2 comments

Comments

3 participants
@MichaelRumpler
Contributor

MichaelRumpler commented Oct 15, 2018

Description

Currently Xamarin.Forms.Span is sealed. So I cannot inherit from it to add my own functionality and add my own SpanChildClass to a Label.FormattedText.

Expected Behavior

I can create my own class:

public class MySpan : Xamarin.Forms.Span { /* inject my functionality */ }

and add instances of that class to Label.FormattedText from both Xaml and code.

Actual Behavior

I cannot inherit from Span.

Basic Information

  • Version with issue: 3.3.0.893527-pre3 and master

@pauldipietro pauldipietro added this to New in Triage Oct 15, 2018

@hartez hartez removed this from New in Triage Oct 15, 2018

@StephaneDelcroix

This comment has been minimized.

Member

StephaneDelcroix commented Oct 16, 2018

I don't see any reason, except runtime overload resolving, that we should keep it sealed. @jassmith: opinion ?

@davidbritch

This comment has been minimized.

Collaborator

davidbritch commented Oct 19, 2018

I'll second the need for this enhancement. Now that Forms 3.3 has the ability to create hyperlink Spans it would be useful if users could create their own HyperlinkSpan controls to avoid code repetition (setting text color, text decoration, and a tap gesture recognizer) every time they want a hyperlink on a Span.

@jfversluis jfversluis referenced this issue Nov 7, 2018

Merged

[Core] Unseal Span #4331

2 of 3 tasks complete

@PureWeen PureWeen added this to In Progress in vNext+1 (master) Nov 7, 2018

@rmarinho rmarinho added this to Done in Enhancements via automation Nov 8, 2018

rmarinho added a commit that referenced this issue Nov 8, 2018

@PureWeen PureWeen moved this from In Progress to Done in vNext+1 (master) Nov 9, 2018

@PureWeen PureWeen removed this from Done in Enhancements Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment