Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] WebView breaks previewer on Android #4107

Closed
PureWeen opened this issue Oct 16, 2018 · 0 comments · Fixed by #4428

Comments

@PureWeen
Copy link
Contributor

commented Oct 16, 2018

Description

The following line fails on Previewer because Context isn't of type activity on Previewer

_webChromeClient.SetContext(Context as Activity);

When this is fixed please do a code sweep for any other places in code where Context is being casted to Activity

Steps to Reproduce

  1. Add a WebView to a FormsPage
  2. Use the previewer and look at the Android View

Expected Behavior

Previewer should render Page

Actual Behavior

Previewer crashes

Basic Information

  • Version with issue: 3.0+
  • Last known good version: 2.5

VS bug #707174, VS bug #730124

@pauldipietro pauldipietro added this to New in Triage Oct 16, 2018

@PureWeen PureWeen removed this from New in Triage Oct 16, 2018

@PureWeen PureWeen added this to To do in Sprint 143 via automation Oct 16, 2018

@PureWeen PureWeen added the e/2 🕑 label Oct 16, 2018

@PureWeen PureWeen removed this from To do in Sprint 143 Oct 23, 2018

@samhouts samhouts added this to To do in Sprint 144 Oct 31, 2018

@rmarinho rmarinho self-assigned this Nov 15, 2018

@rmarinho rmarinho moved this from To do to In progress in Sprint 144 Nov 15, 2018

@rmarinho rmarinho moved this from In progress to Ready for Review (Issues) in Sprint 144 Nov 15, 2018

@samhouts samhouts added this to In Progress in v3.6.0 Nov 19, 2018

Sprint 144 automation moved this from Ready for Review (Issues) to Done Nov 21, 2018

rmarinho added a commit that referenced this issue Nov 21, 2018
[Android] Remove WebViewRenderer dependency on Activity (#4428) fixes #…
…4107

* [Android] Remove WebViewRenderer dependency on Activity

* [Android] Don' t try cast Context as Activity

@samhouts samhouts moved this from In Progress to Done in v3.6.0 Nov 26, 2018

@samhouts samhouts added this to In Progress in v4.0.0 Feb 2, 2019

@samhouts samhouts removed this from Done in v3.6.0 Feb 2, 2019

@samhouts samhouts moved this from In Progress to Done in v4.0.0 Feb 4, 2019

@samhouts samhouts added this to In Progress in v4.1.0 Mar 2, 2019

@samhouts samhouts removed this from Done in v4.0.0 Mar 2, 2019

@samhouts samhouts moved this from In Progress to Done in v4.1.0 Mar 4, 2019

@samhouts samhouts added this to In Progress in vCurrent (4.2.0) May 29, 2019

@samhouts samhouts removed this from Done in v4.1.0 May 29, 2019

@samhouts samhouts moved this from In Progress to Done in vCurrent (4.2.0) May 29, 2019

@samhouts samhouts removed this from Done in vCurrent (4.2.0) Jul 4, 2019

@samhouts samhouts added this to In Progress in vNext (4.3.0) Jul 8, 2019

@samhouts samhouts moved this from In Progress to Done in vNext (4.3.0) Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.