New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] 3.3 SR1 breaks Images on api 17 for fast renderers #4274

Closed
PureWeen opened this Issue Oct 31, 2018 · 1 comment

Comments

2 participants
@PureWeen
Copy link
Contributor

PureWeen commented Oct 31, 2018

Description

This API isn't available pre 18 so it needs a build version check

ClipBounds = GetScaleType() == ScaleType.CenterCrop ? new Rect(0, 0, right - left, bottom - top) : null;

The behavior of setting ClippedBounds should probably be rolled into a static method so in the future when this is used it'll check for that API. That check is already used elsewhere in the code to check the ClippedBounds

Steps to Reproduce

  1. Set the Control Gallery to use fast renderers
  2. Run the Control Gallery on API 17 device
  3. Go to Image Gallery
  4. crashes

Expected Behavior

Shouldn't crash

Actual Behavior

Currently crashes

Basic Information

  • Version with issue: 3.3 SR1
  • Last known good version: 3.3
  • IDE:
  • Platform Target Frameworks:
    • Android: API 17

@PureWeen PureWeen added this to the 3.4.0 milestone Oct 31, 2018

@PureWeen PureWeen added this to Ready in vNext (Target 3.5.0) via automation Oct 31, 2018

@pauldipietro pauldipietro added this to New in Triage Oct 31, 2018

@PureWeen PureWeen removed this from New in Triage Oct 31, 2018

@PureWeen PureWeen added the p/Android label Oct 31, 2018

@PureWeen PureWeen changed the title 3.3 SR1 breaks Images on api 17 for fast renderers [Android] 3.3 SR1 breaks Images on api 17 for fast renderers Oct 31, 2018

@samhouts samhouts removed this from Ready in vNext (Target 3.5.0) Nov 19, 2018

@samhouts samhouts added this to New in Triage via automation Nov 20, 2018

@samhouts samhouts added the t/bug 🐛 label Nov 20, 2018

@samhouts samhouts moved this from New to Ready For Work in Triage Nov 20, 2018

@samhouts samhouts added the e/1 🕐 label Nov 28, 2018

@samhouts samhouts removed this from Ready For Work in Triage Nov 29, 2018

@samhouts samhouts added this to To do in Sprint 146 Dec 15, 2018

@samhouts samhouts added this to To do in Sprint 147 Jan 9, 2019

@PureWeen

This comment has been minimized.

Copy link
Contributor

PureWeen commented Jan 11, 2019

duplicate of #4789

@PureWeen PureWeen closed this Jan 11, 2019

vCurrent (Target 3.4.0) automation moved this from Ready to Done Jan 11, 2019

Android Ready For Work automation moved this from To do to Done Jan 11, 2019

Sprint 147 automation moved this from To do to Done Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment