Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] TabbedPage's child is appearing before it should be #4303

Closed
toussam opened this issue Nov 5, 2018 · 0 comments · Fixed by #4309

Comments

@toussam
Copy link

commented Nov 5, 2018

Hi guys,

Description

I noticed an issue when the MainPage is set with a TabbedPage that is containing several children and where one of them is also a TabbedPage. This child's OnAppearing method is being trigger before the user tap on the related tab.

Steps to Reproduce

  1. Open the provided sample into Visual Studio
  2. Set some breakpoints into every pages' contructor and OnAppearing method
  3. Launch the solution on an Android device
  4. Observe the issue

Expected Behavior

The TabbedPage child's OnAppearing method shouldn't be trigger once the app is running.

Actual Behavior

The TabbedPage child's OnAppearing method is being trigger once the app is running.

Basic Information

  • Version with issue: 3.1.0.697729 (default one) and 3.3.0.912540 (last one)
  • Last known good version: N/A
  • IDE: Visual Studio 2017 v15.8.8
  • Platform Target Frameworks:
    • Android: android:minSdkVersion="15" and android:targetSdkVersion="28"
  • Android Support Library Version: 27.0.2

Reproduction Link

Cf. the attached sample

I thank you in advance for your response and wish you a great week !
Best regards,

TabbedPageIssue.zip

@pauldipietro pauldipietro added this to New in Triage Nov 5, 2018

@rmarinho rmarinho moved this from New to Ready For Work in Triage Nov 5, 2018

rmarinho added a commit that referenced this issue Nov 5, 2018

@PureWeen PureWeen added this to In Progress in v3.6.0 Nov 6, 2018

@PureWeen PureWeen removed this from Ready For Work in Triage Nov 6, 2018

rmarinho added a commit that referenced this issue Nov 9, 2018
[Android] Fix TabbedPage appearing when inside other PageContainer (#…
…4309) fixes #4303

* [Controls] Add repo for issue #4303

* [Android] Don't fire Appearing if we are inside a PageContainer

@PureWeen PureWeen moved this from In Progress to Done in v3.6.0 Nov 11, 2018

@samhouts samhouts removed this from Done in v3.6.0 Jan 3, 2019

@samhouts samhouts added this to In Progress in v3.5.0 Jan 11, 2019

@samhouts samhouts moved this from In Progress to Done in v3.5.0 Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.