Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnPlatform/OnIdiom markup extension not working using NamedSize #4319

Closed
EmilAlipiev opened this issue Nov 6, 2018 · 1 comment · Fixed by #4500

Comments

@EmilAlipiev
Copy link
Contributor

commented Nov 6, 2018

Description
This nice new markup facility doesn't seem to work in a style if i use NamedSize

Steps to Reproduce

add resource style for label as below

<Setter Property="FontSize" Value="{OnIdiom Phone=Micro, Default=Small}" />

Expected Behavior

it works like below one

<Setter Property="FontSize" >         
    <OnIdiom x:TypeArguments="Font" Phone="Micro" Tablet="Small" Desktop="Small" />         
</Setter>

it works like

Basic Information
Version with issue: 3.3

@pauldipietro pauldipietro added this to New in Triage Nov 6, 2018

@rmarinho rmarinho moved this from New to Ready For Work in Triage Nov 6, 2018

@samhouts samhouts added this to To do in Other Ready For Work Nov 19, 2018

@samhouts samhouts removed this from Ready For Work in Triage Nov 19, 2018

@StephaneDelcroix StephaneDelcroix added e/5 🕔 and removed e/3 🕒 labels Nov 21, 2018

@StephaneDelcroix

This comment has been minimized.

Copy link
Member

commented Nov 21, 2018

the title complains about OnPlatform, the sample applies to OnIdiom. I guess both markup extensions have the same issue...

StephaneDelcroix added a commit that referenced this issue Nov 21, 2018
[Xaml] OnIdiomMarkupExt uses converters on BPs
Up to now, OnPlatform and OnIdiom markup extensions were checking for
type converters on
- target type
- the property being set

in case of a bindable property, the converter on the BP getter or
GetBP() static method (for attached BPs) wasn't checked.

This PR adds the check for that, plus a unit test.

- fixes #4319

@EmilAlipiev EmilAlipiev changed the title OnPlatform markup extension not working using NamedSize OnPlatform/OnIdiom markup extension not working using NamedSize Nov 21, 2018

@samhouts samhouts added this to In Progress in v3.6.0 Nov 21, 2018

Other Ready For Work automation moved this from To do to Done Nov 22, 2018

StephaneDelcroix added a commit that referenced this issue Nov 22, 2018
[Xaml] OnIdiomMarkupExt uses converters on BPs (#4500)
Up to now, OnPlatform and OnIdiom markup extensions were checking for
type converters on
- target type
- the property being set

in case of a bindable property, the converter on the BP getter or
GetBP() static method (for attached BPs) wasn't checked.

This PR adds the check for that, plus a unit test.

- fixes #4319

@samhouts samhouts moved this from In Progress to Done in v3.6.0 Nov 22, 2018

@samhouts samhouts removed this from Done in v3.6.0 Jan 3, 2019

@samhouts samhouts added this to In Progress in v3.5.0 Jan 11, 2019

@samhouts samhouts moved this from In Progress to Done in v3.5.0 Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.