Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previewer broken with latest Xamarin.Forms master builds #4351

Closed
rmarinho opened this issue Nov 8, 2018 · 0 comments · Fixed by #4355

Comments

@rmarinho
Copy link
Member

commented Nov 8, 2018

We have removed iPlatform in a PR and we think we broke the Forms Previewer.
This PR removed it: #4235

To Reproduce:
You can try a nightly package 3.5.0.987565-nightly from MyGet feed and try run the previewer.

Logs :

[2018-11-07 22:08:55.5] ERROR: : AndroidXamlRenderer had a rendering error: System.NullReferenceException: Object reference not set to an instance of an object
Xamarin.Forms.Previewer.XamarinFormsLoader.SetPlatform (System.Object page)
Xamarin.Forms.Previewer.XamarinFormsLoader.LoadFromXaml (MonoTouch.Design.XamlRenderContext context)
AndroidFormsRendering.XFPageRendererView.Initialize (System.Int32 contentId)

[2018-11-07 22:08:55.5] ERROR: : The renderer encountered an error while rendering this file: System.NullReferenceException: Object reference not set to an instance of an object
Xamarin.Forms.Previewer.XamarinFormsLoader.SetPlatform (System.Object page)
Xamarin.Forms.Previewer.XamarinFormsLoader.LoadFromXaml (MonoTouch.Design.XamlRenderContext context)
AndroidFormsRendering.XFPageRendererView.Initialize (System.Int32 contentId)
2018-11-07 22:29:45.2] INFO: Reloading: Server rendering completed in 19ms
[2018-11-07 22:29:45.2] ERROR: : iOSXamlRenderer had a rendering error: System.NullReferenceException: Object reference not set to an instance of an object
Xamarin.Forms.Previewer.XamarinFormsLoader.SetPlatform (System.Object page) in /Users/vsts/agent/2.141.1/work/1/s/Xamarin.Designer.iOS/MonoTouch.Design.Server/XamlViewer/XamarinFormsLoader.cs:217
Xamarin.Forms.Previewer.XamarinFormsLoader.LoadFromXaml (MonoTouch.Design.XamlRenderContext context) in /Users/vsts/agent/2.141.1/work/1/s/Xamarin.Designer.iOS/MonoTouch.Design.Server/XamlViewer/XamarinFormsLoader.cs:255
MonoTouch.Design.Server.XamlToPng.RenderOneXaml (MonoTouch.Design.XamlRenderContext context, MonoTouch.Design.XamlFormFactor formFactor) in /Users/vsts/agent/2.141.1/work/1/s/Xamarin.Designer.iOS/MonoTouch.Design.Server/XamlViewer/XamlToPng.cs:64

VS bug #725896

@pauldipietro pauldipietro added this to New in Triage Nov 8, 2018

@rmarinho rmarinho moved this from New to Ready For Work in Triage Nov 8, 2018

@hartez hartez self-assigned this Nov 8, 2018

hartez added a commit that referenced this issue Nov 8, 2018

@hartez hartez added this to To do in Other Ready For Work via automation Nov 8, 2018

@hartez hartez removed this from Ready For Work in Triage Nov 8, 2018

@hartez hartez moved this from To do to In progress in Other Ready For Work Nov 8, 2018

@PureWeen PureWeen added this to In Progress in v3.6.0 Nov 9, 2018

Other Ready For Work automation moved this from In progress to Done Nov 9, 2018

rmarinho added a commit that referenced this issue Nov 9, 2018
Add fake Platform property to Page to keep Previewer happy (#4355) fixes
 #4351

* Add fake Platform property to Page to keep Previewer happy: fixes #4351

* Make the fake Platform property internal

* Add unit tests to verify Previewer-required stuff in Core has not be changed

* Adding Obsolete to Page.Platform

@PureWeen PureWeen moved this from In Progress to Done in v3.6.0 Nov 11, 2018

@samhouts samhouts removed this from Done in v3.6.0 Jan 3, 2019

@samhouts samhouts added this to In Progress in v3.5.0 Jan 11, 2019

@samhouts samhouts moved this from In Progress to Done in v3.5.0 Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.