Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shell] Shell push/pop Navigation broken #4603

Closed
PureWeen opened this issue Dec 1, 2018 · 2 comments

Comments

@PureWeen
Copy link
Contributor

commented Dec 1, 2018

Description

It looks like the Navigational Proxy tree isn't being constructed correctly. From Shell when you try to do Page.Navigation.Push it's supposed to trickle up to the ShellSection and the ShellSection will handle the navigation but it appears the ShellSection Proxy isn't making it onto the Proxy hierarchy tree so the call eventually just reaches the exception

System.InvalidOperationException: PushAsync is not supported globally on iOS, please use a NavigationPage.
  at Xamarin.Forms.Platform.iOS.Platform.Xamarin.Forms.INavigation.PushAsync (Xamarin.Forms.Page root, System.Boolean animated) [0x00000] in <6bd0fb13d90840a685ae60ec5bc317ae>:0
  at Xamarin.Forms.Internals.NavigationProxy.OnPushAsync (Xamarin.Forms.Page page, System.Boolean animated) [0x00022] in D:\a\1\s\Xamarin.Forms.Core\NavigationProxy.cs:198
  at Xamarin.Forms.Internals.NavigationProxy.PushAsync (Xamarin.Forms.Page root, System.Boolean animated) [0x00013] in D:\a\1\s\Xamarin.Forms.Core\NavigationProxy.cs:117
  at Xamarin.Forms.Internals.NavigationProxy.OnPushAsync (Xamarin.Forms.Page page, System.Boolean animated) [0x00022] in D:\a\1\s\Xamarin.Forms.Core\NavigationProxy.cs:198
  at Xamarin.Forms.Internals.NavigationProxy.PushAsync (Xamarin.Forms.Page root, System.Boolean animated) [0x00013] in D:\a\1\s\Xamarin.Forms.Core\NavigationProxy.cs:117
  at Xamarin.Forms.Internals.NavigationProxy.OnPushAsync (Xamarin.Forms.Page page, System.Boolean animated) [0x00022] in D:\a\1\s\Xamarin.Forms.Core\NavigationProxy.cs:198
  at Xamarin.Forms.Internals.NavigationProxy.PushAsync (Xamarin.Forms.Page root, System.Boolean animated) [0x00013] in D:\a\1\s\Xamarin.Forms.Core\NavigationProxy.cs:117
  at Xamarin.Forms.Internals.NavigationProxy.PushAsync (Xamarin.Forms.Page root) [0x00000] in

Steps to Reproduce

Run store gallery
click Push Page

Expected Behavior

A page is pushed

Actual Behavior

App crashes

@pauldipietro pauldipietro added this to New in Triage Dec 1, 2018

@PureWeen PureWeen referenced this issue Dec 1, 2018
3 of 3 tasks complete

@PureWeen PureWeen moved this from New to Ready For Work in Triage Dec 1, 2018

Triage automation moved this from Ready For Work to Closed Dec 3, 2018

@samhouts samhouts added this to In Progress in v3.5.0 Dec 3, 2018

@samhouts samhouts moved this from In Progress to Done in v3.5.0 Dec 3, 2018

@samhouts samhouts removed this from Closed in Triage Dec 3, 2018

@samhouts samhouts removed this from Done in v3.5.0 Dec 4, 2018

@samhouts samhouts added this to In Progress in v3.5.0 Jan 11, 2019

@samhouts samhouts moved this from In Progress to Done in v3.5.0 Jan 11, 2019

@PureWeen PureWeen reopened this Apr 1, 2019

@PureWeen PureWeen self-assigned this Apr 1, 2019

@PureWeen PureWeen added this to To do in Sprint 151 via automation Apr 1, 2019

@PureWeen PureWeen added this to the 4.0.0 milestone Apr 1, 2019

@samhouts samhouts moved this from To do to In progress in Sprint 151 Apr 2, 2019

@samhouts samhouts added the blocker label Apr 4, 2019

@PureWeen

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

duplicate of #4769

@PureWeen PureWeen closed this Apr 17, 2019

Sprint 151 automation moved this from In progress to Done Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.