New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color for picker title #4669

Closed
hugodantas opened this Issue Dec 6, 2018 · 0 comments

Comments

1 participant
@hugodantas
Copy link

hugodantas commented Dec 6, 2018

Summary

Add the property TitleColor for Pickers to be like the PlaceholderColor in Entries.

API Changes

New attribute for Picker called TitleColor (see Entry.PlaceholderColor)

XAML:

<Picker TitleColor="#EAEAEA" />
// or
<Picker TitleColor="Gray" />

C#:

var picker = new Picker();
picker.TitleColor = Color.Gray;
// or
picker.TitleColor = Color.FromHex("#EAEAEA");

Intended Use Case

Use the property Picker.TitleColor to harmony with the others interface element colors eliminating the necessity to create a Custom Renderer.

@pauldipietro pauldipietro added this to New in Triage Dec 6, 2018

@kingces95 kingces95 removed this from New in Triage Dec 6, 2018

@jfversluis jfversluis referenced this issue Dec 11, 2018

Merged

[C, iOS, AND, UWP] Color for Picker.Title #4701

2 of 3 tasks complete

@samhouts samhouts added this to In Progress in vNext+1 (master) Dec 11, 2018

@StephaneDelcroix StephaneDelcroix added this to Done in Enhancements via automation Dec 18, 2018

StephaneDelcroix added a commit that referenced this issue Dec 18, 2018

[C, iOS, AND, UWP] Color for Picker.Title (#4701)
* Implemented Core, iOS and Android

* Implemented UWP

* Processed code review feedback

* More code review feedback
And implemented reset scenarios for all platforms

* Also apply color to popup dialog on Android

- fixes #4669

@samhouts samhouts moved this from In Progress to Done in vNext+1 (master) Dec 18, 2018

@samhouts samhouts removed this from Done in Enhancements Dec 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment